[janelleenqi] iP #75

janelleenqi · 2023-09-05T13:31:52Z

pull request 1

TongZhengHong · 2023-09-07T09:39:03Z

src/main/java/Duke.java

+        System.out.println("Hello! I'm\n" + logo);
+        System.out.println("What can I do for you?");
+
+        Task[] theList = new Task[100];


Consider using a more descriptive name such as taskList instead of theList

TongZhengHong · 2023-09-07T09:41:07Z

src/main/java/Duke.java

+
+        String echo = userInput.nextLine();
+
+        while (!echo.equals("bye")) {


Consider declaring static final constants for each command (e.g. bye, list, mark) so that they can be easily referenced and updated for future use

Suggested change

while (!echo.equals("bye")) {

private static final String BYE_COMMAND = "bye";

while (!echo.equals("bye")) {

TongZhengHong · 2023-09-07T09:43:39Z

src/main/java/Task.java

@@ -0,0 +1,27 @@
+public class Task {


Good job for using good coding standards in this file! Descriptive names are used for functions and variables

TongZhengHong · 2023-09-07T09:48:39Z

src/main/java/Duke.java

+        Scanner userInput = new Scanner(System.in);
+        int counter = 0;
+
+        String echo = userInput.nextLine();


Can consider making some changes to the following variables:

echo should be renamed to userInputString instead since your default command is now adding a new task

userInput should contain the scanner keyword such as inputScanner to better signify that it is the scanner object

SebasFok

Clear code and good use of white space to make the code clean and easy to read. Good job!

SebasFok · 2023-09-07T10:15:53Z

src/main/java/Duke.java

+        while (!echo.equals("bye")) {
+            String[] words = echo.split(" "); //to identify usage of features "mark" & "unmark"
+
+            if (echo.equals("list")) {


Could potentially use a switch if possible to make the code more readable.

SebasFok · 2023-09-07T10:18:46Z

src/main/java/Duke.java

+
+        Task[] theList = new Task[100];
+        Scanner userInput = new Scanner(System.in);
+        int counter = 0;


Perhaps the counter variable could be more descriptive to allow the reader to understand what it is counting.

SebasFok · 2023-09-07T10:21:58Z

src/main/java/Task.java

+    }
+
+    //...
+}


I like your use of descriptive names to make the code clear and concise.

YongbinWang

Overall good job for your ip so far. Take note of how you name your variables, using clear and appropriate names can improve the readability of your code. Keep up the good work!

YongbinWang · 2023-09-16T06:19:10Z

src/main/java/Duke.java

+        Scanner userInput = new Scanner(System.in);
+        int counter = 0;
+
+        String echo = userInput.nextLine();


Consider using a more suitable name for echo so that it is more descriptive for the reader.

YongbinWang · 2023-09-16T06:21:41Z

src/main/java/Duke.java

+            switch (action) {
+                case LIST:


There is a violation of Java coding standard here. There should be no indentation for case clauses. Please configure your IDE to follow the coding standard.

YongbinWang · 2023-09-16T06:23:18Z

src/main/java/Duke.java

+
+                case DEADLINE:
+                    taskDescription = echo.substring(8);
+                    slashCut = taskDescription.indexOf("/");


Consider renaming this variable to make it more descriptive.

…at ExitCommand can be called

Level-9 PR

Add JavaDoc Comments

…" are created if they do not exist

janelleenqi added 2 commits September 4, 2023 18:57

rename "Duke" to "Luke", and added greetings

a4564e4

add echo feature

860d878

janelleenqi closed this Sep 5, 2023

janelleenqi reopened this Sep 5, 2023

janelleenqi changed the title ~~janelleenqi iP~~ [janelleenqi] iP Sep 5, 2023

janelleenqi added 4 commits September 5, 2023 22:15

add features (add, list but reverse)

35b72fc

amend features (add, list)

5fc8ba6

add feature (mark as done)

8e02823

tweaks to follow naming conventions

6b19f57

TongZhengHong reviewed Sep 7, 2023

View reviewed changes

SebasFok reviewed Sep 7, 2023

View reviewed changes

janelleenqi added 6 commits September 8, 2023 00:39

Added three different task types (ToDos, Events, Deadlines)

aebc096

Added three different task types (ToDos, Events, Deadlines)

17570b2

Added three different task types (ToDos, Events, Deadlines)

10bcaae

Added three different task types (ToDos, Events, Deadlines)

b503333

Added Text-UI-Testing

5bae015

Revise formatting, Implement enum & switch

2702b6e

YongbinWang reviewed Sep 16, 2023

View reviewed changes

janelleenqi added 12 commits September 18, 2023 01:04

make Task an abstract task

7796691

fix lines spaced part 2

39b457c

fix lines spaced part 2

573e246

remove unnecessary line

bf1f72b

IntelliJ recommendations

7087e36

add some try-catch blocks

0609792

add some try-catch blocks and throw-catch blocks

e41f732

add try-catch blocks and throw-catch blocks for random words

6c7aeb7

change to more specific error message lines

4320721

change to even more specific error message lines and fix list error

f6e4a2d

throw error if deadline format is wrong

5dc30d9

throw error if event format is wrong

e0a2e01

janelleenqi added 30 commits October 5, 2023 20:42

Fix Objects (Ui)

3190778

Fix Luke to get a code that can run

b99923f

Add "BYE" to ActionType, Add "BYE" case to Parser parse method, so th…

1109f04

…at ExitCommand can be called

Fix small errors

3ad68bf

Fix - "bye" ends Luke without scanner errors

de661a4

Fix Retrieval of Memory (syntax)

a466466

Print correct and specific error messages for errors

4342a65

Fix spacing in memory storage/retrieval

698d964

Code Organisation

41f428d

Merge branch 'branch-A-MoreOOP'

3d28a78

Add JavaDoc comments

b8fe251

Fix Level-9

54c9b4c

Merge pull request #1 from janelleenqi/branch-Level-9

afa9433

Level-9 PR

Merge branch 'master' into branch-A-JavaDoc

3d45534

Merge pull request #2 from janelleenqi/branch-A-JavaDoc

1845d33

Add JavaDoc Comments

Update docs\README.md

56970bd

Update docs\README.md part 2

688c7da

Update docs\README.md part 3

3ed4739

Update docs\README.md part 4

a1a0256

Update Level 7 Save: Luke runs even if no memory.txt exists

f21791f

Update Level 7 Save: Luke runs even if no memory.txt exists part 2

e1e19fb

Update Level 7 Save: directory "data" is created and file "memory.txt…

5c566bd

…" are created if they do not exist

Rename LukeTimeError to LukeException

2e094bf

Refine error from invalid user input

4e9d393

Catch NumberFormatException errors for delete, mark and unmark

05973a4

Refine error messages

2294806

Add user guide within Luke application

bfe863a

Edit JavaDoc Comments

bef32d4

Minor Edit

bd4a715

Fix Memory Saving for Task Completion Status

e27b225

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[janelleenqi] iP #75

[janelleenqi] iP #75

janelleenqi commented Sep 5, 2023

TongZhengHong Sep 7, 2023

TongZhengHong Sep 7, 2023

TongZhengHong Sep 7, 2023

TongZhengHong Sep 7, 2023

SebasFok left a comment

SebasFok Sep 7, 2023

SebasFok Sep 7, 2023

SebasFok Sep 7, 2023

YongbinWang left a comment

YongbinWang Sep 16, 2023

YongbinWang Sep 16, 2023

YongbinWang Sep 16, 2023


		String echo = userInput.nextLine();

		while (!echo.equals("bye")) {

	while (!echo.equals("bye")) {
	private static final String BYE_COMMAND = "bye";
	while (!echo.equals("bye")) {

+                  }
+                  //...
+              }

[janelleenqi] iP #75

Are you sure you want to change the base?

[janelleenqi] iP #75

Conversation

janelleenqi commented Sep 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SebasFok left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YongbinWang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment