[Kherlen Bayasgalan] iP #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remy9926
reviewed
Sep 8, 2023
src/main/java/Duke.java
Outdated
| @@ -1,4 +1,4 @@ | |||
| import java.util.*; | |||
| import java.util.Scanner; | |||
| public class Duke { | |||
| public static String BOT_NAME = "Amy"; // a constant bot name | |||
There was a problem hiding this comment.
Add the "final" modifier to prevent BOT_NAME from being changed at all throughout your program's runtime.
Remy9926
reviewed
Sep 8, 2023
src/main/java/Duke.java
Outdated
| public static void listTasks() { | ||
| System.out.println("Here are the tasks in your list:"); | ||
| for (int i = 0; i < numberOfTasks; i++) { | ||
| System.out.println((i + 1) + ". " + taskList[i]); // list if the user enters list |
There was a problem hiding this comment.
Some of these comments are redundant as it is already made clear in your program what they are made to do
src/main/java/Duke.java
Outdated
| add_List(); | ||
| Scanner scanner = new Scanner(System.in); | ||
| while (true) { | ||
| String userInput = scanner.nextLine(); // Read user input |
src/main/java/Duke.java
Outdated
| String userInput = scanner.nextLine(); // Read user input | ||
| System.out.println("____________________________________________________________"); | ||
| if (userInput.equals("bye")) { | ||
| break; // Exit the loop if the user enters "bye" |
src/main/java/Task.java
Outdated
| isDone = false; | ||
| } | ||
| public String getStatusIcon() { | ||
| return (isDone ? "X" : " "); // mark done task with X |
madhanse
reviewed
Sep 17, 2023
src/main/java/Duke.java
Outdated
| if (userInput.equals("bye")) { | ||
| break; // Exit the loop if the user enters "bye" | ||
| } else if (userInput.equals("list")) { | ||
| listTasks(); // list tasks |
There was a problem hiding this comment.
Remove comments which are very obvious and keep the number of comments minimal
* branch-Level-7: Create txt file Add Save & Load # Conflicts: # src/main/java/AMY/AMY.java
Merging PRs
* branch-Level-9: Add EmptyFindException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.