Create rating api #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backend/controllers/rate.js
Outdated
| @@ -0,0 +1,22 @@ | |||
| // Load required packages | |||
| var Rate = require('../models/history.js'); | |||
There was a problem hiding this comment.
line 2: variable naming convention should be lowerCamelCase
backend/controllers/rate.js
Outdated
| // Save the rating and check for errors | ||
| Rate.build({score: score, movie_id: movieId, user_id: userId}) | ||
| .save().then(function (success) { | ||
| res.json({message: 'Ratings successfully posted!'}); |
There was a problem hiding this comment.
line 12: JSON format, I think break lines around curly brackets should be used, even though it is just one line json
backend/controllers/rate.js
Outdated
| // Create endpoint /api/ratings for GET | ||
| exports.getRates = function (req, res) { | ||
| // Use the Ratings model to find all clients | ||
| Rate.findAll({where: {user_id: req.user.id}}).then(function(ratings){ |
Shadowsong27
requested changes
Feb 12, 2017
backend/controllers/rate.js
Outdated
| rate.updateAttributes({ | ||
| score: score | ||
| }).then(function () { | ||
| return res.json({status: 'success', message: 'Ratings Updated'}); |
There was a problem hiding this comment.
Capitalised every first letter in message may not be needed
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #8 #9 #10
Currently not supporting deletion of ratings