-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rating api #30
Merged
Shadowsong27
merged 9 commits into
development-backend
from
development-backend-8-rate-movie-api
Feb 17, 2017
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
365c8dc
Add rating api for backend
zzzzwen 229e33f
Add update function for POST ratings api for existed ratings and Upda…
zzzzwen 1cb5c7f
Merge branch 'development-backend' into development-backend-8-rate-mo…
zzzzwen 552a08c
Code style changes
zzzzwen 1542de2
Include restriction on score in rate
zzzzwen ab093f8
Add test for rate controller
zzzzwen 929551e
Merge branch 'development-backend' into development-backend-8-rate-mo…
zzzzwen 8785e8c
Add check for NaN score
zzzzwen 93042b1
Edit and add more test to rate controller
zzzzwen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
// Load required packages | ||
var Rate = require('../models/history.js'); | ||
|
||
// Create endpoint /api/ratings for POST | ||
exports.postRates = function (req, res) { | ||
var movieId = req.body.movieId; | ||
var score = req.body.score; | ||
var userId = req.user.id; | ||
// Save the rating and check for errors | ||
Rate.build({score: score, movie_id: movieId, user_id: userId}) | ||
.save().then(function (success) { | ||
res.json({message: 'Ratings successfully posted!'}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. line 12: JSON format, I think break lines around curly brackets should be used, even though it is just one line json |
||
}); | ||
}; | ||
|
||
// Create endpoint /api/ratings for GET | ||
exports.getRates = function (req, res) { | ||
// Use the Ratings model to find all clients | ||
Rate.findAll({where: {user_id: req.user.id}}).then(function(ratings){ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above |
||
res.json(ratings); | ||
}); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 2: variable naming convention should be lowerCamelCase