Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toolkit #64

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Add toolkit #64

merged 1 commit into from
Jan 28, 2024

Conversation

kubouch
Copy link
Contributor

@kubouch kubouch commented Jan 28, 2024

Description

Adds a simple toolkit module that sets a temporary NUPM_xxx environment variables for development to avoid messing up your own setup.

@kubouch
Copy link
Contributor Author

kubouch commented Jan 28, 2024

@amtoine I'll merge it since I need to use it now, but please protest if you don't like it 😄.

@kubouch kubouch merged commit 46d2403 into nushell:main Jan 28, 2024
3 checks passed
@kubouch kubouch deleted the toolkit branch January 28, 2024 12:41
@amtoine
Copy link
Member

amtoine commented Jan 28, 2024

mm, i'm not a big fan of it 😆

two main reasons

  • because i use an automatic toolkit-loading hook i prefer the way i do it with NGM, i.e. use a dedicated command to run the application in a sandbox, on demand only
  • the paths are broken on my system, might be due to the fact i use Nushell to run my window manager, e.g. NUPM_HOME is /home/amtoine/.config/bspwm/_nupm_dev 🤔

@amtoine
Copy link
Member

amtoine commented Jan 28, 2024

but apart from that, the idea is interesting 👍

@kubouch
Copy link
Contributor Author

kubouch commented Jan 28, 2024

OK, so how about that it wouldn't export the env inside export-env but it would give you a def --env set-dev-paths or something that you can call that would set those env vars?

@amtoine
Copy link
Member

amtoine commented Jan 28, 2024

i think it would be better 👍

because, right now, i can't run the following anymore 😢

use nupm
nupm install --path --force .

to install Nupm itself, it tries to put it in the dev environment 😮

@kubouch
Copy link
Contributor Author

kubouch commented Jan 28, 2024

OK, I'll fix it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants