Add hot-reload for server side #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taneliang
approved these changes
Aug 26, 2018
li-kai
force-pushed
the
apollo-server-2
branch
2 times, most recently
from
8e1b004 to
391a416
Compare
li-kai
force-pushed
the
hot-reload-api-server
branch
from
cc3e243 to
c11fde0
Compare
li-kai
force-pushed
the
hot-reload-api-server
branch
from
c11fde0 to
37c8fb3
Compare
|
Deploy preview for nusmods ready! Built with commit ed167b3 |
li-kai
force-pushed
the
hot-reload-api-server
branch
from
37c8fb3 to
062121d
Compare
li-kai
force-pushed
the
hot-reload-api-server
branch
from
062121d to
ed167b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements "hot-reload" via webpack. Right now it technically closes off all requests and sockets and restarts.
Hopefully apollographql/apollo-server#1275 resolves and there will be a better solution. This will do for now.
Also, this opens up the opportunity for ssr. 🕺