Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind all class methods using the keyword "this" #582

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

alfredomariamilano
Copy link

This pull request binds all class methods using the this keyword, so that don't break in certain circumstances, like calling methods dynamically (i.e. using the get function from lodash).

Also, I don't want to break your workflow and it's beyond the scope of this pull request, but having @nut-tree/nl-matcher as a dependency breaks pnpm install if one doesn't have access to it, so a contributor would need to uninstall it first from the examples workspace. Something to keep in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant