Add Prism-based topology discovery #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannickstruyf3
requested review from
tuxtof,
thunderboltsid,
vnephologist and
heiko-koehler
tuxtof
reviewed
Aug 5, 2022
yannickstruyf3
force-pushed
the
feat/prism-topology-discovery
branch
from
8e4e73e
to
9ebe044
Compare
yannickstruyf3
force-pushed
the
feat/prism-topology-discovery
branch
from
9ebe044
to
0fa0251
Compare
tuxtof
approved these changes
Aug 5, 2022
pkg/provider/config/config.go
Outdated
| return nutanixConfig, fmt.Errorf("topologyCategories must be set when using topology discovery type: %s", CategoriesTopologyDiscoveryType) | ||
| } | ||
| default: | ||
| return nutanixConfig, fmt.Errorf("unsupported topology discovery type: %s", nutanixConfig.TopologyDiscovery.Type) |
There was a problem hiding this comment.
Define errors as package variables. This enables client code to distinguish between different types of errors for granular error handling and documentation of errors.
| nutanixConfig.TopologyDiscovery.Type = PrismTopologyDiscoveryType | ||
| case CategoriesTopologyDiscoveryType: | ||
| if nutanixConfig.TopologyDiscovery.TopologyCategories == nil { | ||
| return nutanixConfig, fmt.Errorf("topologyCategories must be set when using topology discovery type: %s", CategoriesTopologyDiscoveryType) |
| Expect(err).ToNot(HaveOccurred()) | ||
| cReader := bytes.NewReader(cBytes) | ||
| _, err = newNtnxCloud(cReader) | ||
| Expect(err).To(HaveOccurred()) |
There was a problem hiding this comment.
If you defined errors as package variables you could compare explicitly
yannickstruyf3
force-pushed
the
feat/prism-topology-discovery
branch
from
0fa0251
to
289673c
Compare
✅ None of your dependencies violate policy! |
|
+1 on @heiko-koehler suggestion on an errors package for unifying error categories and specific errors as directly referenceable for testing assertions. However, we can do that refactoring in a separate PR. |
thunderboltsid
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows Category based topology and also Prism based topology (PC = Region, PE=Zone). Also makes enabling custom labels optional.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):N/A
How Has This Been Tested?:
make unit-test
Special notes for your reviewer:
This PR changes the configmap structure used by CCM
Release note: