Skip to content

Commit

Permalink
Enabled k8s conformance test (#118)
Browse files Browse the repository at this point in the history
* [WIP] Changes to make use of ginkgo v2

Ref: kubernetes-sigs/cluster-api#6906

* KRBN-5429 added validation for machine template parameters

* fixes for supporting ginkgo v2

* fixed panic by calling setupsinglehandler only once

* updated package with cve fixes

* Added clusterctl upgrades related fixes

* added proper contracts for each providers for upgrade to work

* fixed metadata.yaml

* corrected versions

* KRBN-5429 added validation for machine template parameters

* removed changed from other pr

* removed changes from other PR

* added more labels

* removed fail-fast so that ginkgo runs all the tests in CI

* added pure conformance test for capx

* updated labels

* added nutanix copyright

* added TODO comment and copyright

* added correct labels
  • Loading branch information
deepakm-ntnx committed Aug 30, 2022
1 parent 6807399 commit 79ed097
Show file tree
Hide file tree
Showing 16 changed files with 139 additions and 52 deletions.
14 changes: 13 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ SHELL = /usr/bin/env bash -o pipefail
.SHELLFLAGS = -ec

LABEL_FILTERS ?=
JUNIT_REPORT_FILE ?= "junit.e2e_suite.1.xml"
GINKGO_SKIP ?=
GINKGO_NODES ?= 1
E2E_CONF_FILE ?= ${E2E_DIR}/config/nutanix.yaml
Expand Down Expand Up @@ -265,6 +266,7 @@ cluster-e2e-templates-v1beta1: $(KUSTOMIZE) ## Generate cluster templates for v1
$(KUSTOMIZE) build $(NUTANIX_E2E_TEMPLATES)/v1beta1/cluster-template-no-nmt --load-restrictor LoadRestrictionsNone > $(NUTANIX_E2E_TEMPLATES)/v1beta1/cluster-template-no-nmt.yaml
$(KUSTOMIZE) build $(NUTANIX_E2E_TEMPLATES)/v1beta1/cluster-template-project --load-restrictor LoadRestrictionsNone > $(NUTANIX_E2E_TEMPLATES)/v1beta1/cluster-template-project.yaml
$(KUSTOMIZE) build $(NUTANIX_E2E_TEMPLATES)/v1beta1/cluster-template-ccm --load-restrictor LoadRestrictionsNone > $(NUTANIX_E2E_TEMPLATES)/v1beta1/cluster-template-ccm.yaml
$(KUSTOMIZE) build $(NUTANIX_E2E_TEMPLATES)/v1beta1/cluster-template-upgrades --load-restrictor LoadRestrictionsNone > $(NUTANIX_E2E_TEMPLATES)/v1beta1/cluster-template-upgrades.yaml
$(KUSTOMIZE) build $(NUTANIX_E2E_TEMPLATES)/v1beta1/cluster-template-md-remediation --load-restrictor LoadRestrictionsNone > $(NUTANIX_E2E_TEMPLATES)/v1beta1/cluster-template-md-remediation.yaml
$(KUSTOMIZE) build $(NUTANIX_E2E_TEMPLATES)/v1beta1/cluster-template-kcp-remediation --load-restrictor LoadRestrictionsNone > $(NUTANIX_E2E_TEMPLATES)/v1beta1/cluster-template-kcp-remediation.yaml

Expand Down Expand Up @@ -325,7 +327,17 @@ test-kubectl-workload: ## Run kubectl queries to get all capx workload related o
test-e2e: docker-build-e2e $(GINKGO_BIN) cluster-e2e-templates cluster-templates ## Run the end-to-end tests
mkdir -p $(ARTIFACTS)
$(GINKGO) -v --trace --tags=e2e --label-filter="$(LABEL_FILTERS)" $(_SKIP_ARGS) --nodes=$(GINKGO_NODES) \
--no-color=$(GINKGO_NOCOLOR) --output-dir="$(ARTIFACTS)" --junit-report="junit.e2e_suite.1.xml" \
--no-color=$(GINKGO_NOCOLOR) --output-dir="$(ARTIFACTS)" --junit-report=${JUNIT_REPORT_FILE} \
$(GINKGO_ARGS) ./test/e2e -- \
-e2e.artifacts-folder="$(ARTIFACTS)" \
-e2e.config="$(E2E_CONF_FILE)" \
-e2e.skip-resource-cleanup=$(SKIP_RESOURCE_CLEANUP) -e2e.use-existing-cluster=$(USE_EXISTING_CLUSTER)

.PHONY: list-e2e
list-e2e: docker-build-e2e $(GINKGO_BIN) cluster-e2e-templates cluster-templates ## Run the end-to-end tests
mkdir -p $(ARTIFACTS)
$(GINKGO) -v --trace --dry-run --tags=e2e --label-filter="$(LABEL_FILTERS)" $(_SKIP_ARGS) --nodes=$(GINKGO_NODES) \
--no-color=$(GINKGO_NOCOLOR) --output-dir="$(ARTIFACTS)" \
$(GINKGO_ARGS) ./test/e2e -- \
-e2e.artifacts-folder="$(ARTIFACTS)" \
-e2e.config="$(E2E_CONF_FILE)" \
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/categories_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const (
defaultNonExistingAdditionalCategoryValue = "nonExistingCategoryValueCAPX"
)

var _ = Describe("Nutanix categories", func() {
var _ = Describe("Nutanix categories", Label("capx-feature-test", "categories", "slow", "network"), func() {
const (
specName = "cluster-categories"
)
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/ccm_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import (
"sigs.k8s.io/cluster-api/test/framework/clusterctl"
)

var _ = Describe("Nutanix flavor CCM", func() {
var _ = Describe("Nutanix flavor CCM", Label("capx-feature-test", "ccm", "slow", "network"), func() {
const (
specName = "cluster-ccm"
ccmInstanceTypeKey = "node.kubernetes.io/instance-type"
Expand Down
9 changes: 5 additions & 4 deletions test/e2e/cluster_upgrade_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// +build e2e

/*
Copyright 2022 Nutanix, Inc
Copyright 2021 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
Expand All @@ -27,7 +28,7 @@ import (
"sigs.k8s.io/cluster-api/test/framework/clusterctl"
)

var _ = Describe("When upgrading a workload cluster and testing K8S conformance [Conformance] [K8s-Upgrade]", func() {
var _ = Describe("When upgrading a workload cluster and testing K8S conformance", Label("cluster-upgrade-conformance", "slow", "network"), func() {
capi_e2e.ClusterUpgradeConformanceSpec(ctx, func() capi_e2e.ClusterUpgradeConformanceSpecInput {
return capi_e2e.ClusterUpgradeConformanceSpecInput{
E2EConfig: e2eConfig,
Expand Down Expand Up @@ -55,7 +56,7 @@ var _ = Describe("When upgrading a workload cluster and testing K8S conformance
// })
// })

var _ = Describe("When upgrading a workload cluster with a single control plane machine", func() {
var _ = Describe("When upgrading a workload cluster with a single control plane machine", Label("cluster-upgrade-conformance", "slow", "network"), func() {
capi_e2e.ClusterUpgradeConformanceSpec(ctx, func() capi_e2e.ClusterUpgradeConformanceSpecInput {
return capi_e2e.ClusterUpgradeConformanceSpecInput{
E2EConfig: e2eConfig,
Expand All @@ -73,7 +74,7 @@ var _ = Describe("When upgrading a workload cluster with a single control plane
})
})

var _ = Describe("When upgrading a workload cluster with a HA control plane", func() {
var _ = Describe("When upgrading a workload cluster with a HA control plane", Label("cluster-upgrade-conformance", "slow", "network"), func() {
capi_e2e.ClusterUpgradeConformanceSpec(ctx, func() capi_e2e.ClusterUpgradeConformanceSpecInput {
return capi_e2e.ClusterUpgradeConformanceSpecInput{
E2EConfig: e2eConfig,
Expand All @@ -91,7 +92,7 @@ var _ = Describe("When upgrading a workload cluster with a HA control plane", fu
})
})

var _ = Describe("When upgrading a workload cluster with a HA control plane using scale-in rollout", func() {
var _ = Describe("When upgrading a workload cluster with a HA control plane using scale-in rollout", Label("cluster-upgrade-conformance", "slow", "network"), func() {
capi_e2e.ClusterUpgradeConformanceSpec(ctx, func() capi_e2e.ClusterUpgradeConformanceSpecInput {
return capi_e2e.ClusterUpgradeConformanceSpecInput{
E2EConfig: e2eConfig,
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/clusterctl_upgrade_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
capi_e2e "sigs.k8s.io/cluster-api/test/e2e"
)

var _ = Describe("When testing clusterctl upgrades [clusterctl-Upgrade]", func() {
var _ = Describe("When testing clusterctl upgrades [clusterctl-Upgrade]", Label("clusterctl-upgrade", "slow", "network"), func() {
capi_e2e.ClusterctlUpgradeSpec(ctx, func() capi_e2e.ClusterctlUpgradeSpecInput {
return capi_e2e.ClusterctlUpgradeSpecInput{
E2EConfig: e2eConfig,
Expand Down
108 changes: 86 additions & 22 deletions test/e2e/config/nutanix.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,61 +13,121 @@ images:
loadBehavior: mustLoad
# ## PLEASE KEEP THESE UP TO DATE WITH THE COMPONENTS
# Cluster API v1beta1 Preloads
- name: registry.k8s.io/cluster-api/cluster-api-controller:v1.1.4
- name: registry.k8s.io/cluster-api/cluster-api-controller:v1.2.0
loadBehavior: tryLoad
- name: registry.k8s.io/cluster-api/kubeadm-bootstrap-controller:v1.1.4
- name: registry.k8s.io/cluster-api/kubeadm-bootstrap-controller:v1.2.0
loadBehavior: tryLoad
- name: registry.k8s.io/cluster-api/kubeadm-control-plane-controller:v1.1.4
- name: registry.k8s.io/cluster-api/kubeadm-control-plane-controller:v1.2.0
loadBehavior: tryLoad

providers:
- name: cluster-api
type: CoreProvider
versions:
- name: v1.1.4
- name: v0.3.25 # latest published release in the v1alpha3 series; this is used for v1alpha3 --> v1beta1 clusterctl upgrades test only.
value: https://github.com/kubernetes-sigs/cluster-api/releases/download/v0.3.25/core-components.yaml
type: url
contract: v1alpha3
files:
- sourcePath: "../data/shared/metadata.yaml"
replacements:
- old: "imagePullPolicy: Always"
new: "imagePullPolicy: IfNotPresent"
- name: v0.4.7 # latest published release in the v1alpha4 series; this is used for v1alpha4 --> v1beta1 clusterctl upgrades test only.
contract: v1alpha4
value: "https://github.com/kubernetes-sigs/cluster-api/releases/download/v0.4.7/core-components.yaml"
type: "url"
files:
- sourcePath: "../data/shared/metadata.yaml"
replacements:
- old: "imagePullPolicy: Always"
new: "imagePullPolicy: IfNotPresent"
- name: v1.2.0
# Use manifest from source files
value: https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.1.4/core-components.yaml
value: "https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.2.0/core-components.yaml"
type: "url"
contract: v1beta1
files:
- sourcePath: "../data/shared/metadata.yaml"
replacements:
- old: "imagePullPolicy: Always"
new: "imagePullPolicy: IfNotPresent"

- name: kubeadm
type: BootstrapProvider
versions:
- name: v1.1.4
- name: v0.3.25 # latest published release in the v1alpha3 series; this is used for v1alpha3 --> v1beta1 clusterctl upgrades test only.
value: https://github.com/kubernetes-sigs/cluster-api/releases/download/v0.3.25/bootstrap-components.yaml
type: url
contract: v1alpha3
files:
- sourcePath: "../data/shared/metadata.yaml"
replacements:
- old: "imagePullPolicy: Always"
new: "imagePullPolicy: IfNotPresent"
- name: v0.4.7 # latest published release in the v1alpha4 series; this is used for v1alpha4 --> v1beta1 clusterctl upgrades test only.
value: "https://github.com/kubernetes-sigs/cluster-api/releases/download/v0.4.7/bootstrap-components.yaml"
type: "url"
contract: v1alpha4
files:
- sourcePath: "../data/shared/metadata.yaml"
replacements:
- old: "imagePullPolicy: Always"
new: "imagePullPolicy: IfNotPresent"
- name: v1.2.0
# Use manifest from source files
value: https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.1.4/bootstrap-components.yaml
value: "https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.2.0/bootstrap-components.yaml"
type: "url"
contract: "v1beta1"
files:
- sourcePath: "../data/shared/metadata.yaml"
replacements:
- old: "imagePullPolicy: Always"
new: "imagePullPolicy: IfNotPresent"

- name: kubeadm
type: ControlPlaneProvider
versions:
- name: v1.1.4
- name: v0.3.25 # latest published release in the v1alpha3 series; this is used for v1alpha3 --> v1beta1 clusterctl upgrades test only.
value: https://github.com/kubernetes-sigs/cluster-api/releases/download/v0.3.25/control-plane-components.yaml
type: url
contract: v1alpha3
files:
- sourcePath: "../data/shared/metadata.yaml"
replacements:
- old: "imagePullPolicy: Always"
new: "imagePullPolicy: IfNotPresent"
- name: v0.4.7 # latest published release in the v1alpha4 series; this is used for v1alpha4 --> v1beta1 clusterctl upgrades test only.
value: "https://github.com/kubernetes-sigs/cluster-api/releases/download/v0.4.7/control-plane-components.yaml"
type: "url"
contract: v1alpha4
files:
- sourcePath: "../data/shared/metadata.yaml"
replacements:
- old: "imagePullPolicy: Always"
new: "imagePullPolicy: IfNotPresent"
- name: v1.2.0
# Use manifest from source files
value: https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.1.4/control-plane-components.yaml
value: "https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.2.0/control-plane-components.yaml"
type: "url"
contract: v1beta1
files:
- sourcePath: "../data/shared/metadata.yaml"
replacements:
- old: "imagePullPolicy: Always"
new: "imagePullPolicy: IfNotPresent"

- name: nutanix
type: InfrastructureProvider
versions:
- name: v0.4.0 # next; use manifest from source files
type: "url"
value: https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/releases/download/v0.4.0/infrastructure-components.yaml
contract: v1alpha4
replacements:
- old: "imagePullPolicy: Always"
new: "imagePullPolicy: IfNotPresent"
files:
- sourcePath: "../../../metadata.yaml"
- sourcePath: "../data/infrastructure-nutanix/v1alpha4/cluster-template.yaml"
- name: v0.5.0 # next; use manifest from source files
# type: "url"
# value: https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/releases/download/v0.4.0/infrastructure-components.yaml
type: kustomize
value: "../../../config/default"
contract: v1beta1
Expand All @@ -85,6 +145,7 @@ providers:
- sourcePath: "../data/infrastructure-nutanix/v1beta1/cluster-template-no-nmt.yaml"
- sourcePath: "../data/infrastructure-nutanix/v1beta1/cluster-template-project.yaml"
- sourcePath: "../data/infrastructure-nutanix/v1beta1/cluster-template-ccm.yaml"
- sourcePath: "../data/infrastructure-nutanix/v1beta1/cluster-template-upgrades.yaml"
- sourcePath: "../data/infrastructure-nutanix/v1beta1/cluster-template-md-remediation.yaml"
- sourcePath: "../data/infrastructure-nutanix/v1beta1/cluster-template-kcp-remediation.yaml"

Expand All @@ -93,21 +154,23 @@ variables:
# allowing the same e2e config file to be re-used in different Prow jobs e.g. each one with a K8s version permutation.
# The following Kubernetes versions should be the latest versions with already published kindest/node images.
# This avoids building node images in the default case which improves the test duration significantly.
KUBERNETES_VERSION_MANAGEMENT: "v1.21.10"
KUBERNETES_VERSION_MANAGEMENT: "v1.23.6"
IP_FAMILY: "IPv4"
CLUSTERCTL_LOG_LEVEL: 10
NUTANIX_PROVIDER: "true"
NUTANIX_ENDPOINT: ""
NUTANIX_USER: ""
NUTANIX_PASSWORD: ""
NUTANIX_INSECURE: true
KUBERNETES_VERSION: "v1.21.10"
KUBERNETES_VERSION: "v1.23.6"
NUTANIX_SSH_AUTHORIZED_KEY: ""
CONTROL_PLANE_ENDPOINT_IP: ""
CONTROL_PLANE_MACHINE_COUNT: 3
WORKER_MACHINE_COUNT: 3
NUTANIX_PRISM_ELEMENT_CLUSTER_NAME: ""
NUTANIX_MACHINE_TEMPLATE_IMAGE_NAME: "ubuntu-2004-kube-v1.21.10"
NUTANIX_MACHINE_TEMPLATE_IMAGE_NAME: "ubuntu-2004-kube-v1.23.8.qcow2"
CONTROL_PLANE_MACHINE_TEMPLATE_UPGRADE_TO: "ubuntu-2004-kube-v1.24.10.qcow2"
WORKERS_MACHINE_TEMPLATE_UPGRADE_TO: "ubuntu-2004-kube-v1.24.10.qcow2"
NUTANIX_SUBNET_NAME: ""
# NOTE: 'NUTANIX_ADDITIONAL_SUBNET_NAME' is required for multi network interface e2e tests
NUTANIX_ADDITIONAL_SUBNET_NAME: ""
Expand All @@ -118,17 +181,18 @@ variables:
CNI: "./data/cni/kindnet/kindnet.yaml"
EXP_CLUSTER_RESOURCE_SET: "true"
DOCKER_POD_CIDRS: "192.168.0.0/16"
KUBERNETES_VERSION_UPGRADE_TO: "v1.20.0"
KUBERNETES_VERSION_UPGRADE_FROM: "v1.21.8"
KUBERNETES_VERSION_UPGRADE_TO: "v1.24.10"
KUBERNETES_VERSION_UPGRADE_FROM: "v1.23.6"
ETCD_VERSION_UPGRADE_TO: "3.5.3-0"
COREDNS_VERSION_UPGRADE_TO: "v1.8.6"
KUBETEST_CONFIGURATION: "./data/kubetest/conformance.yaml"
# NOTE: INIT_WITH_BINARY and INIT_WITH_KUBERNETES_VERSION are only used by the clusterctl upgrade test to initialize
# the management cluster to be upgraded.
# NOTE: We test the latest release with a previous contract.
INIT_WITH_BINARY: "https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.1.4/clusterctl-{OS}-{ARCH}"
INIT_WITH_BINARY_V1ALPHA4: "https://github.com/kubernetes-sigs/cluster-api/releases/download/v0.4.7/clusterctl-{OS}-{ARCH}"
INIT_WITH_PROVIDERS_CONTRACT: "v1alpha4"
INIT_WITH_KUBERNETES_VERSION: "v1.21.10"
#INIT_WITH_BINARY_V1ALPHA4: "https://github.com/kubernetes-sigs/cluster-api/releases/download/v0.4.7/clusterctl-{OS}-{ARCH}"
#INIT_WITH_PROVIDERS_CONTRACT: "v1alpha4"
INIT_WITH_KUBERNETES_VERSION: "v1.23.6"

intervals:
default/wait-controllers: ["3m", "10s"]
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
bases:
- ../bases/cluster-with-kcp.yaml
- ../bases/secret.yaml
- ../bases/nmt.yaml
- ../bases/crs.yaml
- ../bases/md.yaml
- ../bases/mhc.yaml
8 changes: 8 additions & 0 deletions test/e2e/data/kubetest/conformance.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
ginkgo.focus: \[Conformance\]
ginkgo.skip: \[Serial\]
disable-log-dump: true
ginkgo.progress: true
ginkgo.slowSpecThreshold: 120.0
ginkgo.flakeAttempts: 3
ginkgo.trace: true
ginkgo.v: true
17 changes: 7 additions & 10 deletions test/e2e/data/shared/metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,18 +1,15 @@
apiVersion: clusterctl.cluster.x-k8s.io/v1alpha3
kind: Metadata
releaseSeries:
- major: 1
minor: 1
contract: v1beta1
- major: 1
minor: 0
contract: v1beta1
- major: 0
minor: 4
contract: v1alpha4
- major: 0
minor: 3
contract: v1alpha3
- major: 0
minor: 4
contract: v1alpha4
- major: 1
minor: 2
contract: v1alpha2
contract: v1beta1
- major: 0
minor: 5
contract: v1beta1
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,12 @@
// +build e2e

/*
Copyright 2022 Nutanix, Inc
Copyright 2020 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Expand All @@ -25,9 +23,9 @@ import (
capi_e2e "sigs.k8s.io/cluster-api/test/e2e"
)

var _ = Describe("When testing node drain timeout [node-drain-timeout]", func() {
capi_e2e.NodeDrainTimeoutSpec(ctx, func() capi_e2e.NodeDrainTimeoutSpecInput {
return capi_e2e.NodeDrainTimeoutSpecInput{
var _ = Describe("When testing K8S conformance", Label("conformance", "slow", "network"), func() {
capi_e2e.K8SConformanceSpec(ctx, func() capi_e2e.K8SConformanceSpecInput {
return capi_e2e.K8SConformanceSpecInput{
E2EConfig: e2eConfig,
ClusterctlConfigPath: clusterctlConfigPath,
BootstrapClusterProxy: bootstrapClusterProxy,
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/md_rollout_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
capi_e2e "sigs.k8s.io/cluster-api/test/e2e"
)

var _ = Describe("When testing MachineDeployment rolling upgrades [rolling-upgrades]", func() {
var _ = Describe("When testing MachineDeployment rolling upgrades", Label("md-rolling-upgrades", "slow", "network"), func() {
capi_e2e.MachineDeploymentRolloutSpec(ctx, func() capi_e2e.MachineDeploymentRolloutSpecInput {
return capi_e2e.MachineDeploymentRolloutSpecInput{
E2EConfig: e2eConfig,
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/md_scale_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
capi_e2e "sigs.k8s.io/cluster-api/test/e2e"
)

var _ = Describe("When testing MachineDeployment scale out/in [scale-out-in]", func() {
var _ = Describe("When testing MachineDeployment scale out/in", Label("md-scale-out-in", "slow", "network"), func() {
capi_e2e.MachineDeploymentScaleSpec(ctx, func() capi_e2e.MachineDeploymentScaleSpecInput {
return capi_e2e.MachineDeploymentScaleSpecInput{
E2EConfig: e2eConfig,
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/mhc_remediations_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
capi_e2e "sigs.k8s.io/cluster-api/test/e2e"
)

var _ = Describe("When testing unhealthy machines remediation", Label("health-remediation"), func() {
var _ = Describe("When testing unhealthy machines remediation", Label("machine-health-remediation", "slow", "network"), func() {
capi_e2e.MachineRemediationSpec(ctx, func() capi_e2e.MachineRemediationSpecInput {
return capi_e2e.MachineRemediationSpecInput{
E2EConfig: e2eConfig,
Expand Down
Loading

0 comments on commit 79ed097

Please sign in to comment.