-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to make use of ginkgo v2 #105
Changes to make use of ginkgo v2 #105
Conversation
@@ -323,7 +322,9 @@ test-kubectl-workload: ## Run kubectl queries to get all capx workload related o | |||
.PHONY: test-e2e | |||
test-e2e: docker-build-e2e $(GINKGO_BIN) cluster-e2e-templates cluster-templates ## Run the end-to-end tests | |||
mkdir -p $(ARTIFACTS) | |||
$(GINKGO) -v -trace -tags=e2e -focus="$(GINKGO_FOCUS)" $(_SKIP_ARGS) -nodes=$(GINKGO_NODES) --noColor=$(GINKGO_NOCOLOR) $(GINKGO_ARGS) ./test/e2e -- \ | |||
$(GINKGO) -v --trace --tags=e2e --label-filter="$(LABEL_FILTERS)" --fail-fast $(_SKIP_ARGS) --nodes=$(GINKGO_NODES) \ | |||
--no-color=$(GINKGO_NOCOLOR) --output-dir="$(ARTIFACTS)" --junit-report="junit.e2e_suite.1.xml" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider setting the junit-report via a variable similar to other args
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deepakm-ntnx Please don't resolve without addressing the issue :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thunderboltsid I dont think this needs to be changed at this time to avoid unnecessary variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk; customizable report name usually helps keeping the CI-code cleaner as you don't have to make assumptions around magic strings present in makefiles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main point there is that magic strings tend to replicate across the codebase 🙂
sometimes, across codebases. Which is why these things are usually parameterized to give the calling entity control while having a sane default. With that said, we can do that in a separate PR.
* [WIP] Changes to make use of ginkgo v2 Ref: kubernetes-sigs/cluster-api#6906 * KRBN-5429 added validation for machine template parameters * fixes for supporting ginkgo v2 * fixed panic by calling setupsinglehandler only once * updated package with cve fixes
What this PR does / why we need it:
Ref: kubernetes-sigs/cluster-api#6906
This change upgrades test code to ginkgo v2 and respective cluster-api
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
How Has This Been Tested?:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and test output
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: