feat: adds a validation hook #498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faiq
force-pushed
the
faiq/new-helm-repo
branch
from
89af502
to
77f3c6d
Compare
faiq
force-pushed
the
faiq/new-helm-repo-validation-hook
branch
from
505477e
to
7762832
Compare
supershal
reviewed
Apr 17, 2024
supershal
reviewed
Apr 17, 2024
| return "HelmRegistryValidator" | ||
| } | ||
|
|
||
| func (h *HelmRegistryValidator) ValidateTopology( |
There was a problem hiding this comment.
can we please add a unit test for this
There was a problem hiding this comment.
Im not sure about this particular function, but we can split it out to be more testable
faiq
commented
Apr 17, 2024
| } | ||
|
|
||
| //nolint:gocritic // no need for named results | ||
| func GetRuntimhookVariableByName( |
There was a problem hiding this comment.
Suggested change
| func GetRuntimhookVariableByName( | |
| func GetRuntimehookVariableByName( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the new version of d2iq-labs#56
adds a validation hook for #497