Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Minor golangci-lint config updates for recent versions #552

Merged
merged 1 commit into from
Apr 22, 2024
Merged

build: Minor golangci-lint config updates for recent versions #552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@

run:
timeout: 10m
skip-dirs:
# Although this is actually in api/external, api is a go module
# and so need to specify the dir relative to the module root.
- external
build-tags:
- e2e

Expand Down Expand Up @@ -40,7 +36,6 @@ linters:
- tenv
- thelper
- tparallel
- typecheck
jimmidyson marked this conversation as resolved.
Show resolved Hide resolved
- unconvert
- unparam
- unused
Expand Down Expand Up @@ -93,13 +88,17 @@ linters-settings:
alias: clusterv1

issues:
exclude-dirs:
# Although this is actually in api/external, api is a go module
# and so need to specify the dir relative to the module root.
- external
exclude-rules:
# ignore errcheck for flags.Parse (it is expected that we flag.ExitOnError)
# ignore response.WriteError as it always returns the err it was passed
- source: "flags.Parse|response.WriteError"
linters:
- errcheck
- source: "^// \\+kubebuilder:"
- source: "// \\+kubebuilder:"
linters:
- lll
# Idiomatic to use init functions to register APIs with scheme
Expand Down
Loading