-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kube-vip static Pod in a Nutanix handler #558
Conversation
pkg/handlers/nutanix/mutation/controlplaneendpoint/inject_test.go
Outdated
Show resolved
Hide resolved
pkg/handlers/nutanix/mutation/controlplaneendpoint/inject_test.go
Outdated
Show resolved
Hide resolved
5d0725c
to
b95ddc3
Compare
Is this true? Is there no way a customer could deploy a different load balancer for this? Should this be opt-in (but default true in our templates so effectively opt-out)? |
We just got some feedback from an existing customer that is using an external LB where kube-vip would not be needed. |
@dkoshkin did this work with k8s 1.29.x? |
Good question, the pre/postKubeadmCommands are still in the templates so it should but let me try that. |
be3d179
to
a2a4ba7
Compare
Tested with both Kubernetes v1.28
And v1.29
|
pkg/handlers/generic/mutation/controlplanevirtualip/providers/kubevip.go
Outdated
Show resolved
Hide resolved
pkg/handlers/generic/mutation/controlplanevirtualip/providers/kubevip.go
Show resolved
Hide resolved
pkg/handlers/generic/mutation/controlplanevirtualip/providers/kubevip.go
Show resolved
Hide resolved
Thanks @deepakm-ntnx for the 1.29 question, it made me realize that CAREN should also be responsible for adding the commands, done in e278d2b I did test without this commit and it didn't work because it expects |
a2a4ba7
to
e278d2b
Compare
e278d2b
to
c8a08df
Compare
39621fe
to
3b62fdd
Compare
.../cluster-api-runtime-extensions-nutanix/templates/kube-vip/manifests/kube-vip-configmap.yaml
Outdated
Show resolved
Hide resolved
This will be moved into the handler so that it can be reused.
Currently a virtualIPProvider will always be passed in to the handler, but refactoring to use a builder pattern makes the code more flexible.
3b62fdd
to
d7ef1fd
Compare
Tested with the latest changes after rebase
|
charts/cluster-api-runtime-extensions-nutanix/defaultclusterclasses/nutanix-cluster-class.yaml
Show resolved
Hide resolved
pkg/handlers/generic/mutation/controlplanevirtualip/providers/kubevip.go
Show resolved
Hide resolved
The kube-vip repo uses this format
Co-authored-by: Shalin Patel <shalin.patel@nutanix.com>
eb5bc77
to
2bd290d
Compare
🤖 I have created a release *beep* *boop* --- ## 0.8.0 (2024-04-29) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: give mutators a clusterGetter function by @faiq in https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pull/514it was unintelliga * feat: get default sans via cluster object in patch handler for docker by @faiq in #519 * feat: adds nutanix SANs via patchHandler by @faiq in #522 * feat: nutanix csi driver 3.0 by @faiq in #531 * feat: Add additionalCategories field to Nutanix machine details patch by @dlipovetsky in #525 * feat: support setting Nutanix project on machines by @dkoshkin in #535 * feat: Upgrade to CAPI v1.7.0 by @jimmidyson in #555 * feat: CAPI v1.7.1 by @jimmidyson in #560 * feat: Preserve user-managed fields when applying resources by @dlipovetsky in #556 * feat: Preserve user-managed fields when creating namespace by @dlipovetsky in #557 * feat: Added e2e test for capx cluster by @deepakm-ntnx in #523 * feat: add kube-vip static Pod in a Nutanix handler by @dkoshkin in #558 * feat: AWS CCM for Kubernetes v1.29 by @dkoshkin in #564 ### Fixes 🔧 * fix: updated the capx version used by @deepakm-ntnx in #513 * fix: add omitempty to CCM Credentials struct by @dkoshkin in #524 * fix: Add specific descriptions to Nutanix machine details fields by @dlipovetsky in #532 * refactor: setting ownership references to Nutanix CSI Helm Chart Proxies by @dlipovetsky in #565 ### Other Changes * build: Specify go1.22.2 as toolchain to fix govulncheck issues by @jimmidyson in #517 * build: Add metadata for latest v0.7.0 release by @jimmidyson in #515 * refactor: Consistently import CAPI v1beta1 package as clusterv1 alias by @jimmidyson in #518 * build: Fix image tags in release manifests by @jimmidyson in #516 * test(e2e): Use same versions of providers from module dependencies by @jimmidyson in #521 * build: update aws credentials on kind bootstrap cluster by @supershal in #507 * refactor: standardize the code for getting Helm values by @dkoshkin in #500 * build: Use latest k8s for dev and test management cluster by @jimmidyson in #526 * docs: Add how to release doc by @jimmidyson in #530 * build: adds a .envrc.local file for local development for dotenv by @faiq in #538 * refactor: create storage classes directly instead of using CRS by @faiq in #539 * refactor: Move API to caren.nutanix.com group by @jimmidyson in #534 * build: Add Kubernetes v1.30.0 option for bootstrap and Docker provider by @jimmidyson in #541 * build: create .envrc.e2e file from caren e2e config by @supershal in #540 * build: Only allow patch updates to k8s libs by @jimmidyson in #551 * build: Generate CRD YAML by @jimmidyson in #536 * build: Minor golangci-lint config updates for recent versions by @jimmidyson in #552 * build: generated CRDs yamls by @dkoshkin in #553 * refactor: Use separate types for provider cluster configs by @jimmidyson in #537 * docs: Remove additionalCategories from required fields by @dlipovetsky in #543 * build: Upgrade tooling, notably go to v1.22.2 by @jimmidyson in #561 * refactor: provider an entrypoint to the infra provider meta handlers by @dkoshkin in #554 * test(e2e): Add self-hosted e2e test by @jimmidyson in #439 * build: Bundle k8s.io/* back in with sigs.k8s.io/* dependencies by @jimmidyson in #583 * build: Add envtest setup to e2e envrc by @jimmidyson in #563 ## New Contributors * @deepakm-ntnx made their first contribution in #513 **Full Changelog**: v0.7.0...v0.8.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
What problem does this PR solve?:
Stacked on #554
This PR moves the responsibility of adding the control-plan kube-vip to CAREN away from infra providers.
This has a big benefit of being able to keep this implementation and the image version consistent across the different providers.
Because CAPX is always requires kube-vip to be installed there are no API changes, but in the future we can add support to disable or change the provider.Added an empty
virtualIP{}
struct to NutanixcontrolPlaneEndpoint
.Which issue(s) this PR fixes:
Fixes https://jira.nutanix.com/browse/D2IQ-100364
How Has This Been Tested?:
New unit tests, and tested manually too:
Special notes for your reviewer: