Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add more context to panic in envtest helper #641

Merged
merged 1 commit into from
May 9, 2024
Merged

test: Add more context to panic in envtest helper #641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/helpers/envtest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,9 @@ func getModulePath(moduleDir, moduleName string) string {
cmd.Dir = moduleDir
out, err := cmd.CombinedOutput()
if err != nil {
panic(err)
// We include the combined output because the error is usually
// an exit code, which does not explain why the command failed.
panic(fmt.Sprintf("err=%q, output=%q", err, out))
}
return strings.TrimSpace(string(out))
}
Loading