Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/m overlay subnet #460

Merged

Conversation

Abhishekism9450
Copy link
Contributor

Added:-

  • is_external attribute for External subnet
  • enable_nat
  • vpc_reference_uuid to support Overlay subnet

@abhimutant abhimutant changed the base branch from master to feat/1.6.0 June 9, 2022 06:15
examples/external_subnets/main.tf Outdated Show resolved Hide resolved
examples/external_subnets/main.tf Outdated Show resolved Hide resolved
examples/overlay_subnets/main.tf Outdated Show resolved Hide resolved
examples/overlay_subnets/terraform.tfvars Outdated Show resolved Hide resolved
prefix_length= 16
}
}
data "nutanix_vpc_list" "test" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test is about querying with name but no vpc name mentioned for query. If covered in nutanix_vpc data source test then combine this with first test in this file as it would also require some VPCs to be present initially before
datasource can call

nutanix/data_source_nutanix_vpc_list_test.go Show resolved Hide resolved
nutanix/resource_nutanix_subnet.go Show resolved Hide resolved
@Abhishekism9450
Copy link
Contributor Author

/ok-to-test

@abhimutant
Copy link
Collaborator

abhimutant commented Jun 27, 2022

/ok-to-test pc

Acceptance test run status: cancelled
Current line coverage (0.0) is below threshold (50). Kindly add more acceptance tests.

@abhimutant
Copy link
Collaborator

abhimutant commented Jun 27, 2022

/ok-to-test pc

Acceptance test run status: failure
Current line coverage (42.0) is below threshold (50). Kindly add more acceptance tests.

@abhimutant abhimutant merged commit 1ffca91 into nutanix:feat/1.6.0 Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants