Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert validFrom and validUntil #111

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Conversation

gerardsn
Copy link
Member

These were added as they are in the statuslist2021 spec, but that spec is already aligned with the vc-data-model v2. We are using v1 credentials and should use issuanceDate and expirationDate

Copy link
Member

@reinkrul reinkrul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe specify in the readme which VC data model is supported, and what isn't?

@gerardsn
Copy link
Member Author

JWT-VC and JSON-LD is covered int he readme and we only reference vc-data-model v1

@gerardsn gerardsn merged commit cd573eb into master Mar 28, 2024
1 check passed
@gerardsn gerardsn deleted the revert-validFrom-validUntil branch March 28, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants