-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfixes for integration #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel comfortable being the only reviewer on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. remaining concerns need a rewrite of the library. (VC probably needs to be a map with some public methods for common fields)
When integrating in Nuts node, I came across a few bugs:
JWTCredentialsProofFormat
const nameMarshalJSON()
for Verifiable Credentials in JWT format returned the VC as JSON (as if it were JSON-LD), instead of the parsed JWT VCissuanceDate
,issuer
,proof
). Moved JWT creation function from Nuts node to this library to create JWT credential without setting null/empty properties.expirationDate
in Verifiable Credential in JWT format optional (now led to a zero-edtime.Time
)