Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes for integration #87

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Bugfixes for integration #87

merged 5 commits into from
Oct 20, 2023

Conversation

reinkrul
Copy link
Member

@reinkrul reinkrul commented Oct 18, 2023

When integrating in Nuts node, I came across a few bugs:

  • Typo in JWTCredentialsProofFormat const name
  • MarshalJSON() for Verifiable Credentials in JWT format returned the VC as JSON (as if it were JSON-LD), instead of the parsed JWT VC
  • JWT VCs contained null/empty values for properties that are specified as JWT claims (issuanceDate, issuer, proof). Moved JWT creation function from Nuts node to this library to create JWT credential without setting null/empty properties.
  • Made expirationDate in Verifiable Credential in JWT format optional (now led to a zero-ed time.Time)

@reinkrul reinkrul changed the title Make sure JWT VCs and VPs marshal into the correct format Bugfixes for integration Oct 18, 2023
Copy link
Member

@gerardsn gerardsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel comfortable being the only reviewer on this

vc/vc.go Outdated Show resolved Hide resolved
vc/vc.go Outdated Show resolved Hide resolved
vc/vc.go Outdated Show resolved Hide resolved
Copy link
Member

@gerardsn gerardsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. remaining concerns need a rewrite of the library. (VC probably needs to be a map with some public methods for common fields)

@reinkrul reinkrul merged commit a247b7e into master Oct 20, 2023
1 check passed
@reinkrul reinkrul deleted the jwt-marshal branch October 20, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants