PEX: ldp_vp submission with 1 VC should not index credential property

[reinkrul]

go-did marshals verifiableCredential to a JSON object instead of an array in that case.

[gerardsn]

The VC v1.1 spec is not clear if this can be an object, but all examples are an array. The v2 spec states that it MUST be an array if the field is present. VerifiablePresentation.VerifiableCredential is also always an array in go-did. Am I misinterpreting what you want to fix here?

[gerardsn]

ahh... I think the Unplural in go-did marshaling for VCs in a VP is the bug. Have we used VPs in production yet? If not we can probably just fix that

[reinkrul]

It's not a bug per se, since it's allowed. But it's unconvenient for sure. What makes it complex is that we make the submission before we make the verifiable presentation. So it would be more practical to always marshal to an array, and then we can always use an indexer.

Agree @woutslakhorst ?

[woutslakhorst]

Making it always an array (as specified by v2.0) wouldn't hurt v1.1 so sounds great

[gerardsn]

is this still relevant given nuts-foundation/go-did#98?

[woutslakhorst]

is this still relevant given nuts-foundation/go-did#98?

PR should update to latest go-did and make changes if needed.
There could be a problem for the validation since other implementations could make a VP without an array and we compare one with an array?

[reinkrul]

PR relevant again. Can be reviewed.