Skip to content

Commit

Permalink
Improve the accuracy of a comment in set_transaction_status.
Browse files Browse the repository at this point in the history
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
  • Loading branch information
daira committed Aug 9, 2024
1 parent d96bc11 commit 239f7ff
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions zcash_client_sqlite/src/wallet.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1994,12 +1994,13 @@ pub(crate) fn set_transaction_status(
txid: TxId,
status: TransactionStatus,
) -> Result<(), SqliteClientError> {
// In order to have made a Status request, we must already have had the
// raw transaction (the only callers of `queue_tx_retrieval` are in contexts
// where we must have already called `put_tx_data`). Therefore, it is safe
// to unconditionally delete the request from `tx_retrieval_queue` below
// (both in the expired case and the case where it has been mined), because
// we already have all the data we need about this transaction.
// In order to have made a Status request, we must already have had the raw
// transaction (the only callers of `queue_tx_retrieval` with query type
// GetStatus are in contexts where we must have already called `put_tx_data`).
// Therefore, it is safe to unconditionally delete the request from
// `tx_retrieval_queue` below (both in the expired case and the case where
// it has been mined), because we already have all the data we need about
// this transaction.

match status {
TransactionStatus::TxidNotRecognized | TransactionStatus::NotInMainChain => {
Expand Down

0 comments on commit 239f7ff

Please sign in to comment.