-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multi strategy #61
Conversation
authors: @JesusCrow, @breakingrobot
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=========================================
- Coverage 86.95% 84.05% -2.9%
=========================================
Files 4 4
Lines 46 69 +23
Branches 6 12 +6
=========================================
+ Hits 40 58 +18
- Misses 6 10 +4
- Partials 0 1 +1
Continue to review full report at Codecov.
|
@breakingrobot codecov always adds a comment (or edit it if available) we can't do anything for that :D |
I've tried adding a facebook scheme, not sure I got it right though... SSR is not working and I'm not sure how accessToken is supposed to be sent back to the server. Any insight? I also though about implementing this without SDK not sure what is the preferred way.. |
After talking with @breakingrobot we decided to keep this enhancement
100%99.99 backward compatibles as we are now in rc phase.This is our first step for built-in OAuth support! 🍷
What have been changed:
default
local
scheme.Terminology:
default
local
scheme and compatibility with current options.Task list:
[ ] a wiki page for how-to implementing strategiesAs this is an almost big change, using branch to review changes is better.