-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add support for nuxt 3/nuxt bridge #70
Conversation
Hey @ricardogobbosouza , when do you plan to merge / release this? Thanks |
Can't wait for this to go through! Will fix having to hack a nuxt bridge migration I'm doing. Thanks heaps. |
+1 |
2 similar comments
+1 |
+1 |
This would be highly appreciated. What is missing to complete this? |
Any new on this? @ricardogobbosouza |
I will get back to work on this module now that we have a more stable version of nuxt v3 |
Nuxt 3 just release stable yesterday, so it should be ready to start all over again, thanks for your effort. |
Hi, |
Hi @mukundshah |
Any news? |
Any news on this? |
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
============================================
- Coverage 100.00% 81.42% -18.58%
============================================
Files 2 2
Lines 22 70 +48
Branches 4 6 +2
============================================
+ Hits 22 57 +35
- Misses 0 13 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* refactor: add support for nuxt 3/nuxt bridge * chore: update module * chore: update module * chore: update module * test: add simple test * chore: use `hookOnce` * docs: spli pnpm, yarn and npm
@ricardogobbosouza Using nuxt 2 and nuxt bridge results in the following error
I already removed the node_modules and reinstalled everything again with pnpm. |
Thanks @MartinX3 |
Fixed #80 |
After upgrading
It's unclear to me if v4 is supposed to drop Nuxt 2 support? Changelog wording makes it sound like it's just adding Nuxt Bridge/3 support but it's also in the "Breaking changes" section so I'm not sure if it's a bug or if it's intended (and maybe just need a slightly clearer changelog wording). Thanks! |
@Deckluhm And yes, v4 needs the bridge |
This PR enables this module to work for Nuxt Bridge & Nuxt 3.
Resoles #75, #69, #78
🔥 Notable changes
@nuxt/module-builder
to build module@nuxt/kit