Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't navigate to page with defineI18nRoute(false) #1889

Closed
lukaszflorczak opened this issue Feb 24, 2023 · 7 comments · Fixed by #2240
Closed

Can't navigate to page with defineI18nRoute(false) #1889

lukaszflorczak opened this issue Feb 24, 2023 · 7 comments · Fixed by #2240
Assignees
@kazupon
Labels
good first issue help wanted 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage routing v8

Comments

@lukaszflorczak
Copy link

lukaszflorczak commented Feb 24, 2023 •
edited
Loading

Environment

  • Operating System: Darwin
  • Node Version: v19.6.1
  • Nuxt Version: 3.2.2
  • Nitro Version: 2.2.2
  • Package Manager: pnpm@7.27.1
  • Builder: vite
  • User Config: modules, i18n
  • Runtime Modules: @nuxtjs/i18n@8.0.0-beta.10
  • Build Modules: -

Reproduction

https://stackblitz.com/edit/nuxt-starter-c377bi?file=app.vue

Describe the bug

If the page component has defineI18nRoute(false) it is not possible to navigate to this page on the client side.

I would expect that I can visit that page (URL has no lang prefix), and after returning to another (localized), I will still have the original language set.
@kazupon kazupon added help wanted good first issue v8 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage pending triage routing and removed pending triage labels Feb 25, 2023 — with Volta.net
@borghol borghol mentioned this issue Mar 2, 2023
Merged
7 tasks
@kazupon
Copy link
Collaborator

kazupon commented Mar 3, 2023

This issue has been fixed.
You can install the edge channel version.
Thanks!

@kazupon kazupon closed this as completed Mar 3, 2023
@kazupon
Copy link
Collaborator

kazupon commented Jun 13, 2023

re-open, I've reverted this PR.
#2153

@kazupon kazupon reopened this Jun 13, 2023
@lukaszflorczak
Copy link
Author

Hi @kazupon!

What is the current situation of this issue? Unfortunately, this bug disqualifies beta.13 for me 😔

@kazupon kazupon self-assigned this Jul 11, 2023
@kazupon Volta.net
Copy link
Collaborator

kazupon commented Jul 11, 2023

Oops. I'll work on this issue!

@saifobeidat
Copy link

this is happening with me as well,. did you find any workaround?

or is there any version that doesn't have this issue?

@lukaszflorczak
Copy link
Author

@saifobeidat At this moment I use 8.0.0-beta.12

@kazupon kazupon mentioned this issue Jul 18, 2023
Merged
7 tasks
@kazupon
Copy link
Collaborator

kazupon commented Jul 19, 2023

@lukaszflorczak
Hi!
I fixed this issue, so you can try to install edge channel version.
Happy coding!

@BobbieGoede BobbieGoede mentioned this issue Mar 21, 2024
Merged
9 tasks
BobbieGoede added a commit that referenced this issue Mar 21, 2024
@BobbieGoede
test: merge issue #1889 test (#2867)
f4ef148
DarthGigi pushed a commit to DarthGigi/i18n that referenced this issue Apr 16, 2024
@BobbieGoede
test: merge issue nuxt-modules#1889 test (nuxt-modules#2867)
eadfef9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazupon kazupon

Labels
good first issue help wanted 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage routing v8
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: cannot navigate on toppage nuxt-modules/i18n
3 participants
@kazupon @lukaszflorczak @saifobeidat