Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add httpOnly flag to cookie options in getI18nCookie function #3060

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: add httpOnly flag to cookie options in getI18nCookie function #3060

wants to merge 11 commits into from

Conversation

hoythan
Copy link

@hoythan hoythan commented Aug 13, 2024 •
edited
Loading

🔗 Linked issue

#3059

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #3059

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@hoythan hoythan changed the title V8 feat: add httpOnly flag to cookie options in getI18nCookie function Aug 13, 2024
@BobbieGoede
Copy link
Collaborator

Wouldn't setting httpOnly: true break language switching since the cookie cannot be changed on the client-side? If that is the case, we should add this to the documentation 🤔

@hoythan
Copy link
Author

hoythan commented Aug 16, 2024

Wouldn't setting httpOnly: true break language switching since the cookie cannot be changed on the client-side? If that is the case, we should add this to the documentation 🤔

It’s possible to encounter this issue. While the cookie may not update immediately when the user switches the language using useSwitchLocalePath, it will sync with the address upon refreshing the current page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add httpOnly option to detectBrowserLanguage configuration in i18n
4 participants
@hoythan @BobbieGoede @danielroe @kazupon