Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: separate switchLocalePath SSR feature into plugin #3021

Conversation

BobbieGoede
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I feel like there is a lot going on in the i18n plugin, after looking at Nuxt's source code I noticed some features are separated into plugins, so I tried to do the same here πŸ˜…

I also tried another way of reorganizing the plugin logic here #3017, but that's a bit more involved.

If refactors like these actually make things harder to read, do let me know, I'm too familiar with the codebase now to notice if that is the case πŸ˜‚

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede requested a review from kazupon July 9, 2024 20:50
@BobbieGoede BobbieGoede self-assigned this Jul 9, 2024
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactoring!
Thanks!

@kazupon kazupon merged commit 826cfda into nuxt-modules:main Jul 10, 2024
7 checks passed
BobbieGoede added a commit to BobbieGoede/i18n that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants