-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: restructure extend vue-i18n #3017
Merged
kazupon
merged 12 commits into
nuxt-modules:main
from
BobbieGoede:refactor/restructure-extend-vue-i18n
Jul 11, 2024
Merged
refactor: restructure extend vue-i18n #3017
kazupon
merged 12 commits into
nuxt-modules:main
from
BobbieGoede:refactor/restructure-extend-vue-i18n
Jul 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
BobbieGoede
force-pushed
the
refactor/restructure-extend-vue-i18n
branch
from
July 10, 2024 07:32
5672b82
to
c6d41ea
Compare
kazupon
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Refactoring!
Thank you always! β€οΈ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
We still have some split logic between this module and what was originally in
vue-i18n-routing
, because of this we were extendingvue-i18n
in two places.After some reorganizing I noticed that
onExtendExportGlobal
andonExtendVueI18n
were actually doing the same thing but with different variable names π€ possibly__composerExtend
did the same as well, after merging and generalizing these extends it appears to still be working.I feel like my changes should have broken something.. π Either the refactored code was interchangeable or it contains untested logic π€
π Checklist