Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncRouteParams: false results in an error in plugin.routing when using switchLocalePath #644

Closed
lukaVarga opened this issue Mar 29, 2020 · 1 comment · Fixed by #645
Closed

Comments

@lukaVarga
Copy link

Version

v6.7.0

Reproduction link

https://not-needed.com

Steps to reproduce

Add the following config to vuex:

        vuex: {
          syncRouteParams: false,
        },

Reload the server / page

What is expected ?

App should load and work

What is actually happening?

App fails to load with an error coming from plugin.routing.js - store.getters[${vuex.moduleName}/localeRouteParams](locale) is not a function.

Additional comments?

If syncRouteParams option is false, then the localeRouteParams getter within plugin.main.js does not get registered. However, switchLocalePath function within plugin.routing.js depends on localeRouteParams getter being present (if vuex and store are present, which both holds true with the configuration listed above)

This bug report is available on Nuxt community (#c429)
@rchl
Copy link
Collaborator

rchl commented Mar 29, 2020

Thanks. Fixing in #645.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants