Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lazy load i18n files (2) #2230

Closed
wants to merge 1 commit into from
Closed

fix: lazy load i18n files (2) #2230

wants to merge 1 commit into from

Conversation

userquin
Copy link
Collaborator

πŸ”— Linked issue

Resolves #2192

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #2192

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@userquin
Copy link
Collaborator Author

userquin commented Jul 13, 2023

I guess the playground wasn't working because you don't have included all the locales in the configuration, this new PR just adds all, the default, the initial and the configured ones.

@userquin
Copy link
Collaborator Author

userquin commented Jul 13, 2023

I'll check it in my playground but seems we need to change the order...

EDIT: lazy shouldn't load all the messages, should be a regression when switching the lang since it is not requesting the json file

@userquin userquin closed this Jul 13, 2023
@userquin
Copy link
Collaborator Author

@kazupon it seems the messages are ok, the problem is the available locales, in my tests it is initialized only with the fallback:

imagen

@userquin
Copy link
Collaborator Author

imagen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lazy load files not working
1 participant