fix: Do not pass locale props to NuxtLink #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BobbieGoede |
|
@kazupon |
BobbieGoede
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Looks good to me!
We will have to keep in mind that if we decide to expand the functionality of the NuxtLinkLocale component with more props that we remove those properties before rendering as well.
I think adding tests to confirm the warning is not present is not critical (and not trivial either), so I might look into that later separately.
|
Thanks for contributing! |
DarthGigi
pushed a commit
to DarthGigi/i18n
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#2498
❓ Type of change
📚 Description
Inside
NuxtLinkLocale, do not passlocaleprop when renderingNuxtLink.📝 Checklist