Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(npm): disable shameful hoisting #2503

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

dargmuesli
Copy link
Collaborator

@dargmuesli dargmuesli commented Oct 18, 2023

⚠️ Attention

Builds on top of #2504! Review that one first maybe.

🔗 Linked issue

nuxt/nuxt#14146

❓ Type of change

  • 🧹 Chore
  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Development on this repo should be possible without shameful hoisting. I propose the necessary changes to the root project configuration. The docs directory could get rid of shameful hoisting as well, but that seems to require changes that I do not have at hand right now.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@dargmuesli dargmuesli marked this pull request as ready for review October 18, 2023 13:38
@kazupon kazupon merged commit 333a2bb into nuxt-modules:main Oct 19, 2023
7 checks passed
@dargmuesli dargmuesli deleted the chore/hoisting branch October 19, 2023 12:58
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
* fix(alias): resolve module using nuxt kit

* chore(npm): disable shameful hoisting

* chore(npm): remove configuration

* chore(deps): add `vue-router`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants