fix: prevent strategy no_prefix
redirect detection locale change attempt
#2505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#2493
β Type of change
π Description
Resolves #2493
It looks like
detectRedirect
tried to change locale based on route while usingno_prefix
strategy. This causes issues as we can't retrieve the locale from unprefixed paths.This resolves the referenced issue but potentially a related/underlying issue remains. When resolving the
routePath
here: https://github.com/nuxt-modules/i18n/blob/main/src/runtime/utils.ts#L315-L323 on url with a trailing slash will cause a redirect asroutePath
will resolve to the same path without a trailing slash. In the case of the referenced issue this logic is never hit as the locale does not change.π Checklist