Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support multiple languages on one or more domains while having different domains #2705

Merged
merged 4 commits into from
Mar 23, 2024

Conversation

bjerggaard
Copy link
Contributor

πŸ”— Linked issue

#2418

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This change will support different domains while having more than one language on one or more of the domains.
In order to support the various strategies one must set a domainDefault: true on the default/fallback locale on each domain.

Resolves #2418

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

nuxt-studio bot commented Jan 17, 2024

βœ… Live Preview ready!

Name Edit Preview Latest Commit
i18n Edit on Studio β†—οΈŽ View Live Preview bbef049

@WooHoo-Wu
Copy link

This feature is urgently needed, please release the official version as soon as possible, thank you! ! !

@BobbieGoede BobbieGoede self-assigned this Mar 21, 2024
@BobbieGoede
Copy link
Collaborator

Thanks for contributing!

This PR looks great, I'm happy to see this doesn't seem to introduce any breaking changes. I'm not seeing anything glaring that needs to be changed, what do you think @kazupon?

The configuration for locales is getting a bit complicated, which isn't necessarily an issue but we could consider changing this for v9, feel free to suggest changes in the roadmap discussion #2814 if you have ideas.

Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my late reply.
Looks good feature too me

Thanks

@kazupon kazupon merged commit b7a6c66 into nuxt-modules:main Mar 23, 2024
7 checks passed
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
…different domains (nuxt-modules#2705)

* support multiple languages on one or more domains

* add debug log

* fix after rebase

* update docs
@bezoerb
Copy link

bezoerb commented Jun 5, 2024

This kind of introduces breaking changes as we're not able to use Custom route paths with different domains anymore.
Before this it was possible to omit the strategy option and have localized paths without prefix. This is not possible anymore so we need to downgrade to v8.2.0

Is there any chance to also bring back the old behavior by allowing strategy: 'no_prefix' together with differentDomains: true?

I guess this change here introduces the breaking change:
https://github.com/nuxt-modules/i18n/pull/2705/files#diff-692e2f97144046b5098ccb96849867854a2811345bd2ee991c0fc6d2e47f4a38L34

/cc @BobbieGoede @kazupon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiple languages per domain
5 participants