-
-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support multiple languages on one or more domains while having different domains #2705
feat: Support multiple languages on one or more domains while having different domains #2705
Conversation
β Live Preview ready!
|
This feature is urgently needed, please release the official version as soon as possible, thank you! ! ! |
bbef049
to
83ebbc5
Compare
Thanks for contributing! This PR looks great, I'm happy to see this doesn't seem to introduce any breaking changes. I'm not seeing anything glaring that needs to be changed, what do you think @kazupon? The configuration for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my late reply.
Looks good feature too me
Thanks
β¦different domains (nuxt-modules#2705) * support multiple languages on one or more domains * add debug log * fix after rebase * update docs
This kind of introduces breaking changes as we're not able to use Custom route paths with different domains anymore. Is there any chance to also bring back the old behavior by allowing I guess this change here introduces the breaking change: /cc @BobbieGoede @kazupon |
π Linked issue
#2418
β Type of change
π Description
This change will support different domains while having more than one language on one or more of the domains.
In order to support the various strategies one must set a
domainDefault: true
on the default/fallback locale on each domain.Resolves #2418
π Checklist