fix: strategy: 'no_prefix' when using differentDomains
#3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobbieGoede
changed the title
strategy: 'no_prefix' when using differentDomains
kazupon
approved these changes
Aug 15, 2024
BobbieGoede
added a commit
that referenced
this pull request
Aug 15, 2024
* fix: route localization with `differentDomains` * fix: prevent route removal * fix: `switchLocalePath` resolution for `differentDomains` * docs: update notes to clarify `differentDomains` case
antoinezanardi
referenced
this pull request
in antoinezanardi/werewolves-assistant-web-next
Aug 16, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@nuxtjs/i18n](https://i18n.nuxtjs.org) ([source](https://github.com/nuxt-community/i18n-module)) | [`^8.3.3` -> `^8.4.0`](https://renovatebot.com/diffs/npm/@nuxtjs%2fi18n/8.3.3/8.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>nuxt-community/i18n-module (@​nuxtjs/i18n)</summary> ### [`v8.4.0`](https://github.com/nuxt-modules/i18n/releases/tag/v8.4.0) [Compare Source](https://github.com/nuxt-community/i18n-module/compare/v8.3.3...v8.4.0) ##### 🚀 Features - Configurable directory restructure - by [@​BobbieGoede](https://github.com/BobbieGoede) in [https://github.com/nuxt-modules/i18n/issues/3054](https://github.com/nuxt-modules/i18n/issues/3054) [<samp>(c906a)</samp>](https://github.com/nuxt-modules/i18n/commit/c906a8d9) ##### 🐞 Bug Fixes - Rename locale `iso` property to `language` - by [@​BobbieGoede](https://github.com/BobbieGoede) in [https://github.com/nuxt-modules/i18n/issues/3055](https://github.com/nuxt-modules/i18n/issues/3055) [<samp>(df938)</samp>](https://github.com/nuxt-modules/i18n/commit/df938371) - `strategy: 'no_prefix'` when using `differentDomains` - by [@​BobbieGoede](https://github.com/BobbieGoede) in [https://github.com/nuxt-modules/i18n/issues/3061](https://github.com/nuxt-modules/i18n/issues/3061) [<samp>(53f16)</samp>](https://github.com/nuxt-modules/i18n/commit/53f16e6a) ##### [View changes on GitHub](https://github.com/nuxt-modules/i18n/compare/v8.3.3...v8.4.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/antoinezanardi/werewolves-assistant-web-next). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
This should resolve #3058
I went through the docs and changed the notice on the
no_prefixwhere applicable. Someday I'll try and restructure the docs to better describe the route localization rules as the special cases/notices are a bit scattered through the pages now 🤔📝 Checklist