fix: cookie being reset on reload in ssg build #3087
Merged
+62
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
kazupon
approved these changes
Sep 5, 2024
BobbieGoede
added a commit
that referenced
this pull request
Sep 5, 2024
* fix: cookie being reset on reload in ssg build * test: assert ssg cookie not being reset
antoinezanardi
referenced
this pull request
in antoinezanardi/werewolves-assistant-web-next
Sep 10, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@nuxtjs/i18n](https://i18n.nuxtjs.org) ([source](https://github.com/nuxt-community/i18n-module)) | [`^8.4.0` -> `^8.5.2`](https://renovatebot.com/diffs/npm/@nuxtjs%2fi18n/8.4.0/8.5.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>nuxt-community/i18n-module (@​nuxtjs/i18n)</summary> ### [`v8.5.2`](https://github.com/nuxt-modules/i18n/releases/tag/v8.5.2) [Compare Source](https://github.com/nuxt-community/i18n-module/compare/v8.5.1...v8.5.2) ##### 🐞 Bug Fixes - Cookie being reset on reload in ssg build - by [@​BobbieGoede](https://github.com/BobbieGoede) in [https://github.com/nuxt-modules/i18n/issues/3087](https://github.com/nuxt-modules/i18n/issues/3087) [<samp>(7ccaf)</samp>](https://github.com/nuxt-modules/i18n/commit/7ccaf160) ##### [View changes on GitHub](https://github.com/nuxt-modules/i18n/compare/v8.5.1...v8.5.2) ### [`v8.5.1`](https://github.com/nuxt-modules/i18n/releases/tag/v8.5.1) [Compare Source](https://github.com/nuxt-community/i18n-module/compare/v8.5.0...v8.5.1) ##### 🐞 Bug Fixes - Resolve plugin type import conflicts by updating module builder - by [@​danielroe](https://github.com/danielroe) in [#​3071](https://github.com/nuxt-community/i18n-module/issues/3071) ##### [View changes on GitHub](https://github.com/nuxt-modules/i18n/compare/v8.5.0...v8.5.1) ### [`v8.5.0`](https://github.com/nuxt-modules/i18n/releases/tag/v8.5.0) [Compare Source](https://github.com/nuxt-community/i18n-module/compare/v8.4.0...v8.5.0) ##### 🚀 Features - Add support for multi domain locales - by [@​DotwoodMedia](https://github.com/DotwoodMedia), **Vincent de Vreede** and **DarthGigi** in [https://github.com/nuxt-modules/i18n/issues/3065](https://github.com/nuxt-modules/i18n/issues/3065) [<samp>(93d62)</samp>](https://github.com/nuxt-modules/i18n/commit/93d62226) ##### [View changes on GitHub](https://github.com/nuxt-modules/i18n/compare/v8.4.0...v8.5.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/antoinezanardi/werewolves-assistant-web-next). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOltdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Antoine ZANARDI <antoine.zanardi@epitech.eu>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Should resolve #3066, possibly #2984 too but needs testing. The issue seems to be caused by using the cookie by reference on mounted hook instead of value, causing it to use the updated/reset cookie value on load.
Adding tests for an SSG fixture took a while to figure out but it seems to be working, will need to merge this into v8 as well 😥
📝 Checklist