Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: nuxt context injected function types #3098

Merged

Conversation

BobbieGoede
Copy link
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Should resolve #2168

This fixes the function types and names of the injected context functions, unfortunately fixing this is a breaking change.

I think I know of a way to remove the augmentations in plugins/i18n.ts but that will require larger structural changes, for now the changes in this PR should be sufficient to fix the issue.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BobbieGoede BobbieGoede force-pushed the fix/nuxt-context-injection-types branch from 0cfcce4 to 61ae157 Compare September 13, 2024 15:51
@BobbieGoede BobbieGoede merged commit 97528e9 into nuxt-modules:main Sep 13, 2024
8 checks passed
@BobbieGoede BobbieGoede deleted the fix/nuxt-context-injection-types branch September 13, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_ctx.$localePath is not a function
2 participants