fix: incorrect type checking #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielroe This could do with a urgent review, 0.1.5 was breaking. This module needs tests... |
|
Yes, we do need tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#39
With the release of 0.1.5 additional type checking were added. Issue with this check was that it mismatched the types handled by the Kinde TS SDK.
An exception was added with the type was not a string, but this is breaking the auth flow entirely.
Solution:
Update the memorySession store to match the type of the Kinde TS SDK for
setSessionItemso instead of using the type string, use unknown. (https://github.com/kinde-oss/kinde-typescript-sdk/blob/0239214067fb170336a8b845e4a89f1b6bc9c7aa/lib/sdk/session-managers/BrowserSessionManager.ts#L44)