Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add explicit types for composables & remove baseUrl from tsconfig #404

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

th1m0
Copy link
Contributor

@th1m0 th1m0 commented Aug 28, 2024

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Added explicit types for composables: Ensured composables retain correct types after the build process by adding explicit type definitions.

  • Fixed import issue with Supabase-generated types: Updated the import path for Supabase-generated types to be relative.

  • Removed baseUrl from tsconfig: The baseUrl setting in tsconfig was causing issues with type resolution within the project, so it was removed.

Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for n3-supabase canceled.

Name Link
🔨 Latest commit c92697c
🔍 Latest deploy log https://app.netlify.com/sites/n3-supabase/deploys/66d083a8124d810008b50b94

@larbish larbish merged commit 596ece2 into nuxt-modules:main Aug 29, 2024
5 checks passed
@th1m0 th1m0 deleted the explicit-types branch August 29, 2024 14:41
larbish pushed a commit to felixgabler/supabase-nuxt that referenced this pull request Aug 30, 2024
@larbish
Copy link
Collaborator

larbish commented Aug 30, 2024

@th1m0 Do you have any idea on how to fix the ts error in both src/runtime/plugins/supabase.client.ts and src/runtime/plugins/auth-redirect.ts since the baseUrl was there to prevent this?

Errors happening on build => https://github.com/nuxt-modules/supabase/pull/404/files#file-src-runtime-plugins-auth-redirect-ts-L5

@th1m0
Copy link
Contributor Author

th1m0 commented Aug 30, 2024

It seems the plugins require explicit type annotations. I will make a PR to update this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants