Typecheck error coming from this module

[Yizack]

🐛 The bug

When installing this module in a clean Nuxt app and running the typecheck command npx vue-tsc --noEmit it shows the following error in console

🛠️ To reproduce

https://stackblitz.com/edit/github-qaxbsn

1. Wait for install and dev commands to run
2. Execute npx vue-tsc --noEmit in console

🌈 Expected behaviour

Shouldn't show an error

ℹ️ Additional context

• nuxt: 3.13.2
• vue-tsc: 2.1.6
• @nuxtjs/turnstile: 0.9.6

[dargmuesli]

I'm unsure how to fix this properly, @danielroe may I ask for your assistance?

[Yizack]

I managed to have a fix for this but I'm unsure if this is the right approach

By adding this in /src/module.ts

turnstile/src/module.ts

Lines 128 to 131 in 146cad4

	addTypeTemplate({
	filename: 'types/cloudflare-turnstile.d.ts',
	getContents: () => `/// <reference types="@types/cloudflare-turnstile" />`,
	})

and moving @types/cloudflare-turnstile from devDependencies to dependencies

turnstile/package.json

Lines 55 to 60 in 146cad4

	"dependencies": {
	"@types/cloudflare-turnstile": "0.2.2",
	"@nuxt/kit": "^3.13.1",
	"defu": "^6.1.4",
	"pathe": "^1.1.2"
	},

With these changes we get rid of the type error in a fresh install (deleting node_modules and package-lock.json)

Happy to open a PR if it is ok!

[danielroe]

You're right, it should be a dependency!

Is that sufficient?

Please do open a PR - I will amend as necessary 🙏

[Yizack]

@danielroe it is sufficient! I'm doing it right now!

[dargmuesli-bot]

🎉 This issue has been resolved in version 0.9.7 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[dargmuesli]

Hmm, I still get this type error in the most recent release.

Updated reproduction: https://stackblitz.com/edit/github-qaxbsn-xvnqnd?file=package.json

[danielroe]

seems reference is being stripped somehow

https://unpkg.com/browse/@nuxtjs/turnstile@0.9.8/dist/runtime/composables/turnstile.d.ts

[Yizack]

@danielroe

I'm sorry, I thought it was solved with my change, but I noticed in the previous version 0.9.7 if I have the .npmrc file it doesn't log any error (it did in 0.9.6 even with it, now it's logging the error back in 0.9.8)

I didn't test without the .npmrc file previously

Reproduction: https://stackblitz.com/edit/github-qaxbsn-sal6jg?file=.npmrc,package.json

[danielroe]

I believe this is now hotfixed in 839cbfc.

[Yizack]

It's fixed for me, thank you for addressing the issue!