Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): ensure Turnstile type namespace is registered #339

Merged
merged 4 commits into from
Sep 22, 2024

Conversation

Yizack
Copy link
Contributor

@Yizack Yizack commented Sep 22, 2024

πŸ”— Linked issue

resolves #336

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR fixes the Cloudflare turnstile namespace typecheck

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 25.61%. Comparing base (dc164cc) to head (973e7a4).
Report is 80 commits behind head on main.

Files with missing lines Patch % Lines
src/module.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   19.26%   25.61%   +6.34%     
==========================================
  Files          12       11       -1     
  Lines         493      324     -169     
  Branches       23       22       -1     
==========================================
- Hits           95       83      -12     
+ Misses        398      241     -157     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe danielroe changed the title fix(types): cloudflare turnstile dependency namespace fix(types): ensure Turnstile type namespace is registered Sep 22, 2024
@danielroe danielroe merged commit 2017d46 into nuxt-modules:main Sep 22, 2024
5 checks passed
dargmuesli-bot pushed a commit that referenced this pull request Sep 22, 2024
## [0.9.7](v0.9.6...v0.9.7) (2024-09-22)

### Bug Fixes

* **types:** ensure `Turnstile` type namespace is registered ([#339](#339)) ([2017d46](2017d46))
@dargmuesli-bot
Copy link
Collaborator

πŸŽ‰ This PR is included in version 0.9.7 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@Yizack
Copy link
Contributor Author

Yizack commented Sep 22, 2024

I didn't know those instructions, thank you, I learned something πŸ™πŸΌ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typecheck error coming from this module
3 participants