fix: restore $turnstile types, update and lint project
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's already running for `prepare`.
danielroe
reviewed
Apr 4, 2023
src/runtime/plugins/script.ts
Outdated
| if (process.server) return | ||
| await this.loadTurnstile() | ||
| return (window as any).turnstile.reset(element) | ||
| }, | ||
| } | ||
| } satisfies $turnstile |
There was a problem hiding this comment.
Note to self: We need to fix the lack of typed injection here upstream in nuxt/module-builder.
There was a problem hiding this comment.
Yeah, that would be great! Had to change types in a few places for other modules / projects... and somehow adding types to one project-plugin made the types for all other become invalid 🤔 haven't investigated further on that end yet.
danielroe
approved these changes
Apr 4, 2023
danielroe
changed the title
$turnstile types, update and lint project
dargmuesli
commented
Apr 4, 2023
dargmuesli
commented
Apr 4, 2023
| "@nuxt/module-builder": "0.2.1", | ||
| "@nuxt/schema": "3.3.2", | ||
| "@nuxt/test-utils": "3.3.2", | ||
| "@nuxtjs/eslint-config-typescript": "12.0.0", |
There was a problem hiding this comment.
Is https://github.com/nuxt/eslint-config/tree/main/packages/eslint-config#typescript outdated / can it be removed from the README? I did not notice the difference in nuxt/ vs nuxtjs/ 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'@nuxtjs/eslint-config-typescript', 'plugin:prettier/recommended'with eslintnuxt typecheckconsolainstead of consolesrcfor component type checkingprepare