Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade deps #629

Merged
merged 8 commits into from
Sep 19, 2022
Merged

chore(deps): upgrade deps #629

merged 8 commits into from
Sep 19, 2022

Conversation

Tahul
Copy link
Contributor

@Tahul Tahul commented Sep 12, 2022

This PR upgrade all dependencies and fixes the issue with Pinceau

It will allow to merge https://github.com/nuxt-themes/elements/pull/87

@vercel
Copy link

vercel bot commented Sep 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docus ✅ Ready (Inspect) Visit Preview Sep 19, 2022 at 0:58AM (UTC)

Copy link
Collaborator

FYI, the other issue in PR was a nitro dependency issue which should be resolved shortly. I'll leave it with you whether to downgrade nuxt, but you may wish to stay on edge to get advanced warning of any impact on docus.

@Tahul Tahul changed the title chore(deps): upgrade deps; downgrade nuxt chore(deps): upgrade deps Sep 12, 2022
@Tahul
Copy link
Contributor Author

Tahul commented Sep 12, 2022

@danielroe ; reverted the change :)

package.json Outdated
"@nuxtlabs/github-module": "npm:@nuxtlabs/github-module-edge@latest",
"eslint": "^8.22.0",
"eslint": "^8.23.1",
"nuxt": "npm:nuxt3@latest",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please to not use nuxt-edge unless you need a specific feature of stable releases to avoid such regressions...

Suggested change
"nuxt": "npm:nuxt3@latest",
"nuxt": "^3.0.0-rc.9",

Copy link
Contributor Author

@Tahul Tahul Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we move Nuxt to {dev/peer?}Dependencies anyways, and let the user run Docus with whatever Nuxt version he wants?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's the template that should define the dev dependency to Nuxt.

Agree to use release candidate too and have a way to test the next RC to help the framework team beta test and check any regressions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, ideally should be in devDependencies and still ^3.0.0-rc.9. Please try nuxt-edge for modules and themes on a separate branch only for helping to try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants