Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: port useRequestURL from upstream #1110

Merged
merged 1 commit into from
Feb 13, 2024
Merged

feat: port useRequestURL from upstream #1110

merged 1 commit into from
Feb 13, 2024

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Feb 13, 2024

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Port upstream's useRequestURL composables to Nuxt Bridge as well.
(I'm wondering if I should add @since.)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx changed the title feat: port useRequestURL from upstream feat: port useRequestURL from upstream Feb 13, 2024
danielroe
danielroe approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👌

@danielroe danielroe merged commit 5503879 into main Feb 13, 2024
33 checks passed
@danielroe danielroe deleted the feat/port-use-request-url-from-upstream branch February 13, 2024 13:51
@github-actions github-actions bot mentioned this pull request Feb 13, 2024
Merged
@wattanx wattanx mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wattanx @danielroe