Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to not use @vitejs/plugin-legacy #1164

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Mar 24, 2024

πŸ”— Linked issue

Fixes: #1126

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I want to add an option not to use @vitejs/plugin-legacy.
I believe that having the option not to use @vitejs/plugin-legacy would make it easier to migrate to Nuxt 3 using vite mode.
(I think it will be a big change, so I decided to opt-in.)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx force-pushed the fix/dont-use-legacy-plugin branch 3 times, most recently from 86afd71 to 5ecd098 Compare March 24, 2024 07:23
@wattanx wattanx marked this pull request as ready for review March 24, 2024 07:39
@wattanx wattanx requested a review from danielroe March 24, 2024 07:42
@danielroe danielroe merged commit a6eae9b into main Mar 25, 2024
61 checks passed
@danielroe danielroe deleted the fix/dont-use-legacy-plugin branch March 25, 2024 09:23
@github-actions github-actions bot mentioned this pull request Mar 25, 2024
@wattanx wattanx mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge & Vite: Do not load all chunks at the same time
2 participants