Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: render bodyPrepend in template #837

Merged
merged 4 commits into from
Jul 17, 2023
Merged

fix: render bodyPrepend in template #837

merged 4 commits into from
Jul 17, 2023

Conversation

dwightjack
Copy link
Contributor

These changes apply to packages/bridge/src/runtime/nitro/renderer.ts:

  • Fix a typo in the NuxtRenderHTMLContext object where bodyPreprend should be bodyPrepend (this is a breaking change, I guess)
  • Render the content of the bodyPrepend in the template

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #722

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@dwightjack dwightjack marked this pull request as ready for review June 27, 2023 02:54
@danielroe danielroe changed the title Fix: bodyPrepend support in renderer fix: render bodyPrepend in template Jul 17, 2023
@danielroe danielroe merged commit 659145a into nuxt:main Jul 17, 2023
7 checks passed
@danielroe
Copy link
Member

Thank you ❤️

@dwightjack dwightjack deleted the fix/bodyprepend branch July 18, 2023 00:14
@danielroe danielroe mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing BODY_PREPEND placeholder in app template
2 participants
@dwightjack @danielroe