-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: googleicons provider #133
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 40.00% 40.61% +0.61%
==========================================
Files 57 59 +2
Lines 3435 3560 +125
Branches 433 437 +4
==========================================
+ Hits 1374 1446 +72
- Misses 2023 2075 +52
- Partials 38 39 +1 ☔ View full report in Codecov by Sentry. |
@qwerzl That was quick! Would it be possible to also specificy custom values for the font variations. Currently it's set to |
@AndersCV Would there be a way to detect what you need without configuration, do you think? What does your usage look like? |
Currently we're using the
In our case we have a simple This is purposely done so we can request a font file that is as small in file size as possible, otherwise the whole material symbols font file can be several MBs which is not great. Ideally we would like to reduce the file size further by somehow only including the nessecary icons, but I think thats beyond my expertise. I think our current file size comes down to 440~kb. Detecting this without some form of configuration I don't think is possible as the font-family is applied inside our custom component. |
I guess the first thing we should do is to support setting variable weight ranges. Currently every variable font is defaulted to maximum weight ranges for every provider. |
Sorry for the accidentally closing this PR! Reopening it. |
This PR resolves #127, adds a new
googleicons
provider. One thing that's weird is that Google seems to return an invalid JSON in theirhttps://fonts.google.com/metadata/icons
endpoints (There are random characters on the first line). So the first line is ignored.