Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adobe): use provided css_names from API #192

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

qwerzl
Copy link
Member

@qwerzl qwerzl commented Jul 3, 2024

@danielroe

This PR resolves #187. I'm not sure whether this css_names always have a single value, it's not documented anywhere.

@qwerzl qwerzl requested a review from danielroe as a code owner July 3, 2024 01:33
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jul 3, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.20%. Comparing base (1ca3090) to head (273d5f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   45.20%   45.20%           
=======================================
  Files          56       56           
  Lines        3966     3966           
  Branches      423      423           
=======================================
  Hits         1793     1793           
  Misses       2133     2133           
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/providers/adobe.ts Outdated Show resolved Hide resolved
Co-authored-by: Daniel Roe <daniel@roe.dev>
@qwerzl
Copy link
Member Author

qwerzl commented Jul 4, 2024

@danielroe Merged.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 4, 2024
@danielroe danielroe merged commit 18d22cc into nuxt:main Jul 4, 2024
1 check passed
@danielroe
Copy link
Member

Nice! 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adobe doesn't load
3 participants