This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(nitro, nuxi): add runtimeConfig types (for #config
and useRuntimeConfig()
)
#1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
βοΈ Deploy Preview for nuxt3-docs canceled. π¨ Explore the source changes: ce90b23 π Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/618a729d1a567900076ac6df |
danielroe
added
bug
Something isn't working
documentation
Improvements or additions to documentation
nitro
labels
Nov 8, 2021
danielroe
changed the title
fix(nitro, nuxi): add runtimeConfig types (for #config)
fix(nitro, nuxi): add runtimeConfig types (for Nov 8, 2021
#config
and useRuntimeConfig()
)
pi0
reviewed
Nov 8, 2021
pi0
added
enhancement
New feature or request
and removed
bug
Something isn't working
labels
Nov 8, 2021
tobiasdiez
reviewed
Nov 8, 2021
Co-authored-by: Tobias Diez <code@tobiasdiez.com>
38 tasks
tobiasdiez
reviewed
Nov 9, 2021
tobiasdiez
reviewed
Nov 9, 2021
Co-authored-by: Tobias Diez <code@tobiasdiez.com>
tobiasdiez
reviewed
Nov 9, 2021
danielroe
commented
Nov 9, 2021
Co-authored-by: Tobias Diez <code@tobiasdiez.com>
I hope it's okay to use this PR for a related question: how does one use |
@tobiasdiez you would likely want to use |
pi0
approved these changes
Nov 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3.x
documentation
Improvements or additions to documentation
enhancement
New feature or request
nitro
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves nuxt/nuxt#12837
β Type of change
π Description
This PR:
#config
in Nitro routesuseRuntimeConfig()
privateRuntimeConfig
&publicRuntimeConfig
Note, the way I've implemented this allows us in future to automatically type runtime config.
π Checklist