This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nitro): update nitro internal hook name #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
changed the title
danielroe
changed the title
danielroe
changed the title
pi0
reviewed
Jun 14, 2021
danielroe
force-pushed
the
fix/nitro-template-hook
branch
from
ea09451
to
85718bf
Compare
danielroe
changed the title
atinux
approved these changes
Jun 16, 2021
pi0
reviewed
Jun 16, 2021
| @@ -27,14 +27,14 @@ export default function nuxt2CompatModule () { | |||
| // Connect hooks | |||
| nuxt.addHooks(nitroContext.nuxtHooks) | |||
| nuxt.hook('close', () => nitroContext._internal.hooks.callHook('close')) | |||
| nitroContext._internal.hooks.hook('nitro:document', template => nuxt.callHook('nitro:document', template)) | |||
There was a problem hiding this comment.
Note for the future: We need to once fix two way hooks and avoid manually connecting them.
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes hook name and adds hook to dev context as well - issues left over from #177.