Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(bridge): Build fails with SSR turned off #2708

Merged
merged 5 commits into from
Jan 24, 2022

Conversation

blazmrak
Copy link
Contributor

@blazmrak blazmrak commented Jan 13, 2022

πŸ”— Linked issue

resolves nuxt/bridge#27

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Build now uses ssr setting from nuxt.config, default remains true.

This solves failing builds when ssr is set to false in nuxt.config.

Fixes nuxt/bridge#27 for vite bridge.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jan 13, 2022

βœ”οΈ Deploy Preview for nuxt3-docs ready!

πŸ”¨ Explore the source changes: c20a362

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/61eb304f3d9f2c0007a2abd4

😎 Browse the preview: https://deploy-preview-2708--nuxt3-docs.netlify.app

@toniengelhardt
Copy link
Contributor

Is this fixing [vite]: Rollup failed to resolve import "#config" from "vite/preload-helper" ?

@blazmrak
Copy link
Contributor Author

blazmrak commented Jan 21, 2022

Is this fixing [vite]: Rollup failed to resolve import "#config" from "vite/preload-helper" ?

It shouldn't, at least it was not intended to. That is probably a separate issue.

@danielroe danielroe added bridge vite πŸ”₯ p5-urgent Priority 5: build-breaking bugs that affect most users and should be fixed ASAP labels Jan 21, 2022
@pi0
Copy link
Member

pi0 commented Jan 24, 2022

Thanks πŸ’š

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bridge πŸ”₯ p5-urgent Priority 5: build-breaking bugs that affect most users and should be fixed ASAP vite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails with SSR turned off
4 participants