This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nitro): replace global.
in fewer instances
#3107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves nuxt/nuxt#12777, resolves nuxt/nuxt#13327
β Type of change
π Description
We were being a little over-zealous in our replacement. I hope a stray
global.
won't slip through the net, but by adding a specific list of possible values to replace, we can improve things.An alternative, which is quite tempting, is to write our own rollup plugin that would add a RegExp that's more precisely targeted to this need (vs
@rollup/plugin-replace
which only supports non-RE delimiters).π Checklist