Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix: use perfect-debounce to handle trailing run of promise #3679

Merged
merged 9 commits into from
Mar 16, 2022
Merged

fix: use perfect-debounce to handle trailing run of promise #3679

merged 9 commits into from
Mar 16, 2022

Conversation

danielroe
Copy link
Member

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This fixes the remaining issue with #3656 with https://github.com/unjs/perfect-debounce.

@danielroe danielroe added chore 🧹 p1-chore Priority 1: no change in change code behavior labels Mar 15, 2022
@danielroe danielroe requested a review from pi0 March 15, 2022 20:29
@danielroe danielroe self-assigned this Mar 15, 2022
@netlify
Copy link

netlify bot commented Mar 15, 2022 •
edited
Loading

✔️ Deploy Preview for nuxt3-docs canceled.

🔨 Explore the source changes: 53bc6f9

🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/6231c46004d0b20008e3da01

pi0
pi0 reviewed Mar 15, 2022
View reviewed changes
packages/nitro/src/server/dev.ts Outdated Show resolved Hide resolved
packages/nuxt3/src/core/builder.ts Outdated Show resolved Hide resolved
packages/nuxi/src/commands/dev.ts Outdated Show resolved Hide resolved
packages/bridge/src/vite/server.ts Outdated Show resolved Hide resolved
danielroe and others added 4 commits March 15, 2022 20:40
@danielroe @pi0
Update packages/nitro/src/server/dev.ts
db1b5f1 
Co-authored-by: pooya parsa <pyapar@gmail.com>
@danielroe @pi0
Update packages/nuxt3/src/core/builder.ts
00f5363 
Co-authored-by: pooya parsa <pyapar@gmail.com>
@danielroe @pi0
Update packages/nuxi/src/commands/dev.ts
b762b94 
Co-authored-by: pooya parsa <pyapar@gmail.com>
@danielroe @pi0
Update packages/bridge/src/vite/server.ts
5797c00 
Co-authored-by: pooya parsa <pyapar@gmail.com>
@danielroe
Copy link
Member Author

danielroe commented Mar 15, 2022 •
edited
Loading

@pi0 Would you be okay with moving 100 -> 25 ms default?

@pi0
Copy link
Member

pi0 commented Mar 15, 2022 •
edited
Loading

Would you be okay with moving 100 -> 25 ms default?

Sure thing! What about setting it by default in perfect-debounce? We could use some huristics to detect slower envs and increase default value. (default is 25 in perfect-debounce now. we can also omit)

@pi0 pi0 changed the title refactor: use perfect-debounce to handle trailing run of promise fix: use perfect-debounce to handle trailing run of promise Mar 15, 2022
@pi0 pi0 added enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing and removed chore 🧹 p1-chore Priority 1: no change in change code behavior labels Mar 16, 2022
@pi0 pi0 merged commit ff88d91 into main Mar 16, 2022
@pi0 pi0 deleted the refactor/perfect-debounce branch March 16, 2022 11:11
@danielroe danielroe mentioned this pull request Mar 29, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 left review comments

Assignees

@danielroe danielroe

Labels
3.x enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0